feat: 사용자용 요청 주제(토픽) 생성/조회 API 구현 #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
pparkjs
approved these changes
Oct 27, 2024
| private final String code; | ||
| private final String viewName; | ||
|
|
||
| public static CategoryType codeOf(String code) { | ||
| return Arrays.stream(CategoryType.values()) | ||
| .filter(t -> t.getCode().equals(code)) | ||
| .findAny() | ||
| .orElseThrow(() -> new CustomException(RESOURCE_NOT_FOUND, "해당 카테고리코드는 존재하지 않습니다.")); | ||
| .orElseThrow(() -> new CustomException(RESOURCE_NOT_FOUND, ERROR_MESSAGE + code)); |
| } | ||
| Long cursorId = topics.get(topics.size() - 1).getId(); | ||
| List<TopicDto> topicDtos = TopicDto.toList(topics); | ||
|
|
There was a problem hiding this comment.
이거 PaginationUtils.checkEndPage 메서드를 사용해도 될 거 같은데 대부분 cursorId 페이지네이션은 이 방식으로 쓰고 있어서 만약 통일성을 추구하고 싶으면 이거대로 하고 굳이면 동호님이 하신대로 하셔도 됩니다.!
There was a problem hiding this comment.
추후 리팩터링하는걸로 해볼게요 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
사용자용 요청 주제(토픽) 생성/조회 API를 구현했습니다~
Relation Issues