Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 사용자 추천 API 정책 변경으로 비회원도 사용자 추천 나타나도록 API 수정 #314

Merged
merged 6 commits into from
Oct 27, 2024
Merged

feat: 사용자 추천 API 정책 변경으로 비회원도 사용자 추천 나타나도록 API 수정 #314

merged 6 commits into from
Oct 27, 2024

Conversation

pparkjs
Copy link
Collaborator

@pparkjs pparkjs commented Oct 19, 2024 •
edited by kdkdhoho
Loading

Description

기존 정책

(회원만)

  • 사용자추천 기준 가장 최근에 리스트 update빠른기준
  • 나와 내가 팔로잉한 사람들을 제외한 사용자 추천

변경된 정책

  • (회원) 팔로우하지 않는 사용자 중 가장 최근 리스트 생성 또는 수정한 사용자
  • (비회원) 가장 최근에 리스트 생성 또는 수정한 사용자

Relation Issues

@pparkjs pparkjs self-assigned this Oct 19, 2024
@pparkjs pparkjs requested a review from kdkdhoho as a code owner October 19, 2024 06:00
@pparkjs pparkjs linked an issue Oct 19, 2024 that may be closed by this pull request
추천 사용자 조회 정책 변경에 따른 API 수정 #299
Closed
1 task
kdkdhoho
kdkdhoho reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@kdkdhoho kdkdhoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 남겨두었습니다 ^^7

src/main/java/com/listywave/user/application/dto/UsersRecommendedResponse.java Show resolved Hide resolved
src/main/java/com/listywave/user/application/service/UserService.java Show resolved Hide resolved
src/main/java/com/listywave/user/presentation/UserController.java Outdated Show resolved Hide resolved
src/main/java/com/listywave/user/repository/user/custom/impl/CustomUserRepositoryImpl.java Outdated Show resolved Hide resolved
src/test/java/com/listywave/acceptance/user/UserAcceptanceTest.java Outdated Show resolved Hide resolved
src/test/java/com/listywave/acceptance/user/UserAcceptanceTestHelper.java Outdated Show resolved Hide resolved
@pparkjs
Copy link
Collaborator Author

pparkjs commented Oct 23, 2024

코멘트 남겨두었습니다 ^^7

반영 완료했습니다 ㅎㅎ

kdkdhoho
kdkdhoho approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@kdkdhoho kdkdhoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트가 풍부해져서 좋네요 👍
제안드린 것들 반영해주셔서 감사합니다. Approve 할테니 남은 리뷰는 적절히 반영해서 머지해주세용~

src/test/java/com/listywave/acceptance/user/UserAcceptanceTest.java Outdated Show resolved Hide resolved
src/main/java/com/listywave/collection/application/dto/CollectionResponse.java Outdated Show resolved Hide resolved
@pparkjs pparkjs merged commit 982b8fd into dev Oct 27, 2024
1 check passed
@pparkjs pparkjs deleted the feat/299 branch October 27, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdkdhoho kdkdhoho kdkdhoho approved these changes

Assignees

@pparkjs pparkjs

Labels
기능 테스트
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

추천 사용자 조회 정책 변경에 따른 API 수정
2 participants
@pparkjs @kdkdhoho