feat: Cookie 제거 및 개발용 로그인 개선 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pparkjs
approved these changes
Sep 1, 2024
src/main/java/com/listywave/auth/application/domain/kakao/KakaoOauthClient.java
Show resolved
Hide resolved
Comment on lines
-66
to
-69
| jwtManager.getAccessTokenValidTimeDuration(), | ||
| jwtManager.getRefreshTokenValidTimeDuration(), | ||
| jwtManager.getAccessTokenValidTimeUnit(), | ||
| jwtManager.getRefreshTokenValidTimeUnit() |
There was a problem hiding this comment.
다시 살펴보니 처음부터 불필요하더라구요? ㅎ
필요에 의해서 포함시켰었는데 불필요해보여서 제거했습니다!
Comment on lines
+31
to
+33
| ResponseEntity<LoginResponse> login(@RequestParam("code") String authCode) { | ||
| LoginResponse response = authService.login(authCode); | ||
| return ResponseEntity.ok().body(response); |
There was a problem hiding this comment.
그럼 쿠키에 담아서 안보내고 본문에만 담아서 보내면 프론트단이 편하게 처리할 수 있는 거죠?
There was a problem hiding this comment.
넵! 서버 입장에선 로그인이 성공적으로 이뤄지면 액세스, 리프레시 토큰을 만들고 Body에만 담아주면 됩니다.
그리고 클라이언트에서 토큰을 Authorization 헤더에 담아주면 그 값을 읽어서 처리하면 됩니다.
Comment on lines
100
to
108
| void 로그인에_성공하면_Body와_Authorization헤더에_액세스_토큰과_리프레시_토큰을_담아_응답한다() { | ||
| // when | ||
| var 로그인_응답 = 로그인을_시도한다(expectedKakaoTokenResponse, expectedKakaoMember); | ||
| var 로그인_응답 = 로그인(EXPECTED_KAKAO_TOKEN_RESPONSE, EXPECTED_KAKAO_MEMBER); | ||
| var 로그인_결과 = 로그인_응답.as(LoginResponse.class); | ||
|
|
||
| // then | ||
| assertAll( | ||
| () -> assertThat(로그인_응답.cookie("accessToken")).isNotNull(), | ||
| () -> assertThat(로그인_응답.cookie("accessToken")).isNotBlank(), | ||
| () -> assertThat(로그인_응답.cookie("refreshToken")).isNotNull(), | ||
| () -> assertThat(로그인_응답.cookie("refreshToken")).isNotBlank(), | ||
| () -> assertThat(로그인_결과.accessToken()).isNotNull(), | ||
| () -> assertThat(로그인_결과.accessToken()).isNotBlank(), | ||
| () -> assertThat(로그인_결과.refreshToken()).isNotNull(), | ||
| () -> assertThat(로그인_결과.refreshToken()).isNotBlank() | ||
| () -> assertThat(로그인_결과.accessToken()).isNotNull().isNotBlank(), | ||
| () -> assertThat(로그인_결과.refreshToken()).isNotNull().isNotBlank() |
There was a problem hiding this comment.
수정된 로직보면 body에만 엑세스 토큰, 리프레시 토큰 담아서 응답하는 거 같은데 별도에 Authorization 헤더에도 담는 로직이 있는 건가요?
There was a problem hiding this comment.
아 실수로 메서드명을 수정하지 않았네요!
감사합니다 🙂
Comment on lines
+20
to
+47
| public class DevAccount { | ||
|
|
||
| @Id | ||
| @Column(name = "user_id", nullable = false, unique = true) | ||
| private Long id; | ||
|
|
||
| @MapsId | ||
| @OneToOne(fetch = LAZY) | ||
| @JoinColumn(name = "user_id", nullable = false, unique = true) | ||
| private User user; | ||
|
|
||
| @Column(nullable = false, unique = true) | ||
| private String account; | ||
|
|
||
| @Column(nullable = false) | ||
| private String password; | ||
|
|
||
| public void validatePassword(String password) { | ||
| if (this.password.equals(password)) { | ||
| return; | ||
| } | ||
| throw new IllegalArgumentException("비밀번호가 틀렸습니다."); | ||
| } | ||
|
|
||
| public Long getUserId() { | ||
| return user.getId(); | ||
| } | ||
| } |
There was a problem hiding this comment.
오우 개발용 계정을 관리하는 테이블이 추가되는거군요
There was a problem hiding this comment.
개발용 DB에만 추가할 예정입니다!
src/main/java/com/listywave/auth/dev/presentation/DevAuthController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
Merge 전 DB 작업 내용
Relation Issues