Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat, refactor: ListEntity 관련 전체 리팩터링 및 관련도순 정렬 기능 추가 #126
feat, refactor: ListEntity 관련 전체 리팩터링 및 관련도순 정렬 기능 추가 #126
Changes from 9 commits
c5ce9b3
ca16882
164ef55
c113812
d676849
b9a2fc5
d1345dc
e0a0940
7fceadf
04caa28
4344bdd
09006f5
fff2252
452b613
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 방식이 일급컬렉션 방식이군요 확실히 Collaborator의 관련된 부분을 해당 레벨에서 처리할 수 있어 응집력도 좋아보이고 컬렉션의 불변성도 보장되어 보여 좋아보이네요
동호님 덕분에 좋은 방식 알아갑니다 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그리고 해당부분은 따로 양방향으로 되어 있는 부분이 없어서 별도의 일급컬렉션으로 관리하는거라 @embeddable이 지정이 안되있는게 맞죠!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 맞습니다!
List<Collaborator>
을 의존하는 엔티티가 없어서 굳이@Embeddable
을 달아줄 필요가 없네용This file was deleted.
This file was deleted.