Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 인증 정보 Required로 반영 및 인가 기능 구현 #116

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

kdkdhoho
Copy link
Collaborator

Description

  1. 리스트 및 댓글, 답글 삭제 및 수정 시에 인증 정보가 반드시 포함되도록 수정했습니다. 동시에 인가 기능도 구현했습니다.
  2. AccessToken 앞에 "Bearer " Prefix가 포함되도록 수정했습니다.

Relation Issues

@kdkdhoho kdkdhoho self-assigned this Feb 14, 2024
@kdkdhoho kdkdhoho requested a review from pparkjs as a code owner February 14, 2024 00:49
@kdkdhoho kdkdhoho linked an issue Feb 14, 2024 that may be closed by this pull request
Copy link
Collaborator

@pparkjs pparkjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 확인 해 봤는데 모두 인증 정보 필수적으로 받도록 잘 구현 하셨네요 제 로직도 추후 변경해야겠습니다.

소유자 검증 로직도 굿!

Comment comment = commentRepository.getById(commentId);

if (!comment.canDeleteBy(user)) {
throw new CustomException(INVALID_ACCESS, "댓글은 작성자만 지울 수 있습니다.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

댓글 소유자 검증 굿!

@kdkdhoho kdkdhoho merged commit e2bc766 into dev Feb 14, 2024
1 check passed
@kdkdhoho kdkdhoho deleted the feat/112 branch February 14, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants