Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 예외 관련 리팩터링 #115

Merged
merged 2 commits into from
Feb 14, 2024
Merged

refactor: 예외 관련 리팩터링 #115

merged 2 commits into from
Feb 14, 2024

Conversation

kdkdhoho
Copy link
Collaborator

Description

  • 나현님 요청에 따라 NOT_FOUND의 HttpStatus를 BadRequest로 변경했습니다.
  • 그리고 하는 김에 에러 쪽 리팩터링도 진행했습니다.

Relation Issues

@kdkdhoho kdkdhoho self-assigned this Feb 14, 2024
@kdkdhoho kdkdhoho requested a review from pparkjs as a code owner February 14, 2024 00:10
@kdkdhoho kdkdhoho linked an issue Feb 14, 2024 that may be closed by this pull request
서버에 존재하지 않는 리소스에 접근하면 404 에러를 반환하도록 수정 #113
Closed
1 task
pparkjs
pparkjs approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@pparkjs pparkjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우 예외 부분 깔쌈하게 리팩토링 잘해주셨네요 수고 많으셨습니다!
이제 400은 다 404로 변경됐네요

@kdkdhoho kdkdhoho merged commit 83b0868 into dev Feb 14, 2024
1 check passed
@kdkdhoho kdkdhoho deleted the refactor/113 branch February 14, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pparkjs pparkjs pparkjs approved these changes

Assignees

@kdkdhoho kdkdhoho

Labels
리팩터링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

서버에 존재하지 않는 리소스에 접근하면 404 에러를 반환하도록 수정
2 participants
@kdkdhoho @pparkjs