prod: test35 (#prod)

8-Sprinters · May 28, 2024 · 76ab7a1 · 76ab7a1
1 parent 40c6f6f
commit 76ab7a1
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/.github/workflows/prod-cd.yml b/.github/workflows/prod-cd.yml
@@ -13,11 +13,6 @@ jobs:
         id: ip
         uses: haythem/public-ip@bdddd92c198b0955f0b494a8ebeac529754262ff
 
-      - name: IP 설정
-        run: |
-          echo "AWS_DEFAULT_REGION=${{ secrets.AWS_DEFAULT_REGION }}" >> $GITHUB_ENV
-          echo "AWS_SECURITY_GROUP_NAME=${{ secrets.AWS_SECURITY_GROUP_NAME }}" >> $GITHUB_ENV
-
       - name: AWS 로그인
         uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502
         with:
@@ -27,7 +22,7 @@ jobs:
 
       - name: IP 허용
         run: |
-          aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SECURITY_GROUP_NAME }} --protocol tcp --port ${{ secrets.PROD_EC2_PORT }} --cidr ${{ steps.ip.outputs.ipv4 }}/32
+          aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SECURITY_GROUP_ID }} --protocol "tcp" --port "${{ secrets.PROD_EC2_PORT }}" --cidr "${{ steps.ip.outputs.ipv4 }}/32"
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -108,7 +103,6 @@ jobs:
           key: ${{ secrets.PROD_EC2_PRIVATE_KEY }}
           script_stop: true
           script: |
-            docker stop "${{ secrets.PROD_CONTAINER_NAME }}"
             docker rm -f "${{ secrets.PROD_CONTAINER_NAME }}"
             docker rmi "${{ secrets.DOCKER_HUB_USERNAME }}/${{ secrets.IMAGE_NAME }}:${{ secrets.PROD_TAG }}"
             docker pull "${{ secrets.DOCKER_HUB_USERNAME }}/${{ secrets.IMAGE_NAME }}:${{ secrets.PROD_TAG }}"
@@ -117,7 +111,7 @@ jobs:
       - name: IP 제거
         if: ${{ always() }}
         run: |
-          aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SECURITY_GROUP_NAME }} --protocol tcp --port ${{ secrets.PROD_EC2_PORT }} --cidr ${{ env.IP_ADDRESS }}/32
+          aws ec2 revoke-security-group-ingress --group-name "${{ secrets.AWS_SECURITY_GROUP_ID }}" --protocol "tcp" --port "${{ secrets.PROD_EC2_PORT }}" --cidr "${{ env.IP_ADDRESS }}/32"
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}