Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update comment-release workflow #99

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

seriouslag
Copy link
Collaborator

@seriouslag seriouslag commented Apr 30, 2024

This changes the npm versioning to use the git sha of the current PR and not the main branch.

There is some bug in the comment-release workflow when updating the github comment.

Getting errors saying packageName is not a function

I am trying to understand why that is happening.

https://github.com/7nohe/openapi-react-query-codegen/actions/runs/8888225124/job/24404700180

Copy link

github-actions bot commented Apr 30, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 99.08% (🎯 95%) 1732 / 1748
🟢 Statements 99.08% (🎯 95%) 1732 / 1748
🟢 Functions 100% (🎯 95%) 37 / 37
🟢 Branches 94.8% (🎯 85%) 146 / 154
File CoverageNo changed files found.
Generated in workflow #242

@seriouslag seriouslag self-assigned this Apr 30, 2024
@seriouslag seriouslag added the help wanted Extra attention is needed label Apr 30, 2024
@seriouslag seriouslag requested a review from 7nohe April 30, 2024 02:24
@seriouslag seriouslag force-pushed the fix/debug-update-comment branch from 0ed0283 to 0e6cd78 Compare April 30, 2024 02:31
@seriouslag seriouslag added the bug Something isn't working label Apr 30, 2024
@7nohe 7nohe merged commit d82b34e into main Apr 30, 2024
4 checks passed
@7nohe 7nohe deleted the fix/debug-update-comment branch April 30, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants