-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: convert any CE effect type to a bifunctor effect #1766
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #1766 +/- ##
===========================================
- Coverage 65.39% 63.59% -1.80%
===========================================
Files 557 479 -78
Lines 11061 9636 -1425
Branches 0 491 +491
===========================================
- Hits 7233 6128 -1105
+ Misses 3828 3508 -320 |
Would it be possible to generalize this even further? Namely, given any monofunctor Repeat that for all conversions in |
@mucaho |
be4d382
to
6dda1f0
Compare
Great to see this is still being worked on, thanks! While this was being worked on, I have created my own two conversions I needed in the meantime, not sure if they are completely sound though, in case anyone needs: https://bitbucket.org/mucaho/ceffbanx/src/8986109fb7e9e97c7ae5a71ba311ff9d915634b8/src/main/scala/org/bitbucket/mucaho/ceffbanx/Util.scala#lines-130:180 |
Seems to be working: cats-effect laws pass, but there may still be problems they don't reveal