Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pids #14

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Merge pids #14

wants to merge 5 commits into from

Conversation

batesj
Copy link
Collaborator

@batesj batesj commented Sep 17, 2021

No description provided.

@741g
Copy link
Owner

741g commented Sep 22, 2021

Hi, there's a conflict in vperfetto-sdk.cpp that might be a bit more than purely syntactical:

<<<<<<< merge_pids
    // Use the same offset in case pids and tids are mixed up.
    uint32_t maxPidTid = std::max(maxMainPid, maxMainTid);
    // Use an offset that is easy to read out the original addon pid for debugging.
    uint64_t pidTidOffset = 1000000;
    while(pidTidOffset < maxPidTid)
        pidTidOffset *= 10;

=======
>>>>>>> main

Was there a divergence earlier? If so, please include that commit too. Otherwise, thanks for the fixes and additional tracking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants