Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape key should close the autocomplete before switching to normal mode #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dephiros
Copy link

@dephiros dephiros commented Feb 7, 2024

Currently, when in insert mode and the suggest panel(autocomplete) shows up, hitting escape will close the suggest panel and switch to normal mode.
This change allows the user to only close the suggest panel. To go to normal mode, the user would have to hit escape again.

A situation where this is helpful is when the suggest panel pop up together with github copilot suggestion. We want to stay in insert mode to accept github copilot suggestion

@71
Copy link
Owner

71 commented Feb 11, 2024

Thanks for the suggestion and PR!

package.json is automatically generated and should not be modified. Instead, this line should be modified as it defines the keybinding.

Currently, dance.modes.set.normal runs the command hideSuggestWidget (see link above), so it is somewhat expected that the suggest widget might be opened when switching from insert mode to normal mode. I do agree that it would be better to instead close the suggest widget on escape, but this is somewhat of a breaking change.

I suppose the change needed to do that is

- * | Set mode to Normal | `set.normal` | `escape` (kakoune: insert), `escape` (helix: select) | `[".modes.set", { mode: "normal" }], ["hideSuggestWidget"]` |
+ * | Set mode to Normal | `set.normal` | `escape` (kakoune: insert, "!suggestWidgetVisible"), `escape` (helix: select) | `[".modes.set", { mode: "normal" }]` |

(with the table is reformatted).

And because VS Code keybindings interact in fairly complex ways, this should be tested (locally, no need to add a test) to be sure this works as expected. And CHANGELOG.md should mention the change, with a snippet to restore the previous behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants