feat: Rationalize Equipment Category Schema #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
How was it tested?
I created a new script in src/tests that validates categories and items between "5e-SRD-Equipment-Categories.json" and "5e-SRD-Equipment.json". This ensures that all items categories in "5e-SRD-Equipment.json" are present in "5e-SRD-Equipment-Categories.json". It also ensures that all category items in "5e-SRD-Equipment-Categories.json" are present in "5e-SRD-Equipment.json". Using this method, I found that "Donkey" and "Camel" were both missing from "5e-SRD-Equipment-Categories.json". I also found that 'standard-gear' was missing from ammunition items in "5e-SRD-Equipment.json". I also found that there was no reference to the "land-vehicles" category for land vehicles in "5e-SRD-Equipment.json".
Is there a Github issue this is resolving?
Yes., issue #397 - Equipment category schema rationalization
Did you update the docs in the API? Please link an associated PR if applicable.
No.
Here's a fun image for your troubles