Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rationalize Equipment Category Schema #535

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mpeck451
Copy link

What does this do?

  1. Adds a new "equipment_categories" array for all items within the "5e-SRD-Equipment.json" file.
  2. Creates a new script for category validation in src/tests.
  3. Adds "Donkey" and "Camel" to "5e-SRD-Equipment-Categories.json". (Previously missing)
  4. Adds "standard-gear" to ammunition items in "5e-SRD-Equipment.json". (Present in "5e-SRD-Equipment-Categories.json", but missing in "5e-SRD-Equipment.json")
  5. Adds "land-vehicles" category to land vehicles in "5e-SRD-Equipment.json" (Present in "5e-SRD-Equipment-Categories.json", but missing in "5e-SRD-Equipment.json")

How was it tested?

I created a new script in src/tests that validates categories and items between "5e-SRD-Equipment-Categories.json" and "5e-SRD-Equipment.json". This ensures that all items categories in "5e-SRD-Equipment.json" are present in "5e-SRD-Equipment-Categories.json". It also ensures that all category items in "5e-SRD-Equipment-Categories.json" are present in "5e-SRD-Equipment.json". Using this method, I found that "Donkey" and "Camel" were both missing from "5e-SRD-Equipment-Categories.json". I also found that 'standard-gear' was missing from ammunition items in "5e-SRD-Equipment.json". I also found that there was no reference to the "land-vehicles" category for land vehicles in "5e-SRD-Equipment.json".

Is there a Github issue this is resolving?

Yes., issue #397 - Equipment category schema rationalization

Did you update the docs in the API? Please link an associated PR if applicable.

No.

Here's a fun image for your troubles

random photo - update me

@mpeck451 mpeck451 changed the title Resolve Issue #397 - "Equipment category schema rationalization" feat: Rationalize Equipment Category Schema May 19, 2023
Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! You'll want to cut a separate PR on the API as a few things will need to be updated: Types, GraphQL, and swagger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants