Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] first batch of features data update #284

Draft
wants to merge 5 commits into
base: feature_specific
Choose a base branch
from

Conversation

Freedzio
Copy link
Contributor

I took the liberty of deleting the template.

The structures (besides the ones discussed with @fergcb) are experimental, so I expect a lot of comments :P

src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
src/5e-SRD-Features.json Show resolved Hide resolved
I also added APIReferences here and there
src/5e-SRD-Features.json Outdated Show resolved Hide resolved
@Freedzio Freedzio marked this pull request as draft October 1, 2020 09:01
{
"name": "Rage",
"action_type": "bonus",
"duration": "10 turns",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions don't really have durations, effects do. I think having a duration attribute on each effect makes more sense than the action itself having a duration.

src/5e-SRD-Features.json Outdated Show resolved Hide resolved
"duration": "2 turns",
"desc": "Attack rolls against you have advantage until the end of your next turn"
"name": "Reckless Attack",
"desc": "When you make your first attack on your turn...",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the full description of the action. From the SRD:

When you make your first attack on your turn, you can
decide to attack recklessly. Doing so gives you
advantage on melee weapon attack rolls using
Strength during this turn, but attack rolls against
you have advantage until your next turn.

"url": "/api/conditions/exhaustion",
"level": 1
"name": "Frenzy",
"desc": "When you enter rage, you can go into frenzy instead",
Copy link
Member

@fergcb fergcb Oct 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the description from the SRD:

You go into a frenzy when you rage. For
the duration of your rage you can make a single
melee weapon attack as a bonus action on each of
your turns after this one. When your rage ends, you
suffer one level of exhaustion (as described in
appendix PH-A).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I've also split it into an array

"name": "Frenzy",
"desc": "When you enter rage, you can go into frenzy instead",
"action_type": "bonus",
"duration": "10 turns",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing with duration as above.

"desc": "When you enter rage, you can go into frenzy instead",
"desc": [
"You go into a frenzy when you rage. For the duration of your rage you can make a single melee weapon attack as a bonus action on each of your turns after this one. When your rage ends, you suffer one level of exhaustion (as described in appendix PH-A)",
" If you do so, for the duration of your rage you can make a single melee weapon attack as a bonus action on each of your turns after this one. When your rage ends, you suffer one level of exhaustion (as described in appendix PH-A)."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the second item here is a duplicate.

@bagelbits
Copy link
Collaborator

@Freedzio @fergcb Y'all still working on this?

@fergcb
Copy link
Member

fergcb commented Nov 12, 2020

@Freedzio @fergcb Y'all still working on this?

I haven't heard back from @Freedzio in regards to some of my comments on what he's got so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants