-
Notifications
You must be signed in to change notification settings - Fork 362
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
* feat: add notification bell in header * fix: remove unused prop
* feat: add notification bell in header * fix: remove unused prop * feat: notification popper * fix: mark notifications read on popper close * feat: add scrollbar * fix: chronological sort + increase button size * fix: lint + remove padding * fix: update type, split components + simplify sort * fix: cleanup clickaways * fix: add return type * fix: use popper offset * fix: close poppers relevant to notifications * fix: ordering + don't read pending notifications * fix: remove comment * fix: clickable area of bell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
1 - Notification about a new version for the safe: A safe 1.0.0 for testing: rin:0xFA8A0Ec18381eA8edB018F62Cb1dfF6B641Bf221 2 - This issue happens also in prod. If it can be fixed here great, if not I'll create a new ticket for it. Notification of "Sign the tx" when using a spending limit never go away on their own. The rest of the notifications looks good to me |
Thanks for testing this @francovenica. Both issues should now be fixed. |
Verified:
|
What it solves
Resolves #3950
How this PR fixes it
Notifications are now cached locally and are accessible via a notification centre. It is opened by clicking the bell in the header.
Notifications are unread if the user does not manually close the notification. Unread notifications are displayed at the top of the notification centre and marked as read when closing the notification centre if they were visible in the list.
Note: 'actionable' notifications are not implemented yet, hence why the "Required actions" section of the notification centre/notification actions are not present. These will be implemented as part of the #3951 epic.
How to test it
Dispatch notifications via requesting a transaction signature, accessing a Safe that requires an update, etc. and observe that they are accessible in the notification centre.
Screenshots