Feat: mobile pairing in Safe creation #3867
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
The code looks good to me but has the design been cleared by @liliiaorlenko? The alignment is a bit odd:
A few findings:
-
The alignment of the description in the wallet popper is no longer centred:
-
On high res. screens the two are very far apart:
-
There are failing tests.
|
Strange, wallet connection stopped working. |
Pull Request Test Coverage Report for Build 2337865346
💛 - Coveralls |
katspaugh
force-pushed
the
mobile-pairing-safe-creation
branch
from
2a58393 to
91124aa
Compare
katspaugh
force-pushed
the
mobile-pairing-safe-creation
branch
from
91124aa to
021ea2d
Compare
…airing-safe-creation
…airing-safe-creation
…airing-safe-creation
| @@ -43,3 +43,7 @@ export const saveToStorageWithExpiry = <T = unknown>(key: string, value: T, expi | |||
| export const loadFromStorageWithExpiry = <T = unknown>(key: string): T | undefined => { | |||
| return storage.getWithExpiry<T>(key) | |||
| } | |||
|
|
|||
| export const removeFromStorageWithExpiry = (key: string): void => { | |||
There was a problem hiding this comment.
The name of this threw me off at first.
There was a problem hiding this comment.
It's a hairy name but consistent with the other two.
|
Probably unrelated to this ticket, but the post-connection message is different than what it was. I assume it was changed on purpose Prod: |
|
This is something that only happens in this PR. In dev and prod it works fine. Once you use the QR code, disconnect and use the "reload icon" button to create a new one, the icon in the dropdown is a "zoomed in" version of the QR code, and it doesn't work: To reproduce: |
|
The rest works fine |
Yes, I took the opportunity to groom those messages a bit. |
…airing-safe-creation
|
@francovenica great catch with the QR code refresh, fixed ✅ |
|
The QR code refresh is fixed. Looks good to me |
Part of safe-global/safe-pm#54
Design: https://www.figma.com/file/C9TgnaMpQQvLAEYP8Bvl5X/Mobile-App-on-Web?node-id=60%3A6107
Adds the Mobile Pairing module to the Safe creation stepper.