Feat: add AppStore button in the footer #3710
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 2022842757
💛 - Coveralls |
katspaugh
force-pushed
the
appstore-button
branch
from
12db064 to
d6403ce
Compare
src/components/AppLayout/index.tsx
Outdated
| @@ -122,7 +115,7 @@ const Layout: React.FC<Props> = ({ | |||
| </SidebarWrapper> | |||
| <ContentWrapper> | |||
| <div>{children}</div> | |||
| {hasFooter && <Footer />} | |||
| <Footer /> | |||
There was a problem hiding this comment.
I thought we wanted to hide the footer outside of the welcome page?
There was a problem hiding this comment.
We need it visible on all pages to expose the AppStore badge to as many users as possible.
Also seeing the app version at all times is very helpful.
@lukasschor you mind if we restore the footer?
There was a problem hiding this comment.
I am in general unsure on the value of displaying the App Store badge like this. It feels unnatural and I would prefer to promote the mobile app in parts of the user flows where it is actually relevant (setting up a Safe, connecting a wallet) rather than just promoting it randomly in the footer.
There were some thoughts in not showing the footer everywhere (more screen estate, stronger focus on relevant content). If at all, I would suggest first displaying the app store button in the welcome screen in the footer only and track over some some time the effectiveness of this and how it compares to promoting the app in other places.
But even then, it might be worth exploring other places in the welcome page or onboarding flow where this would fit better.
There was a problem hiding this comment.
Let's consider this a temporary experiment until the next release then. We'll be able to gauge how many users will click on this with the footer visible on every screen.
I've made an issue to revert it here: #3712.
Unless you feel strongly we should not do it, in which case I'll revert it now.
katspaugh
force-pushed
the
appstore-button
branch
from
d6403ce to
f7ac4c0
Compare
|
There are a few guidelines on using the App store badge e.g. it needs to have a minimum height of 40px and 10px whitespace around (one quarter of the height). |
|
@usame-algan good point, but 40 would be too big for the footer. |
What it solves
Part of safe-global/safe-pm#54
How this PR fixes it
Adds a simple button in the footer to boost mobile app installations.
This PR also enables the footer on all pages. It was previously shown only in Settings and Welcome. See #2766.