Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
fix: wrong label space calculation in selects (#189)
Browse files Browse the repository at this point in the history
* Fix wrong calculation for spacing in Selects labels

* Package version

* Storyshots
  • Loading branch information
yagopv authored Mar 8, 2022
1 parent a1d2b38 commit c678149
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@gnosis.pm/safe-react-components",
"version": "1.0.1",
"version": "1.0.2",
"description": "Gnosis UI components",
"main": "dist/index.min.js",
"typings": "dist/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion src/inputs/Select/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function Select({
onOpen={handleOpen}
value={activeItemId}
onChange={handleChange}
label={id ? id : 'generic-select'}
label={label}
variant="outlined"
disabled={disabled}
{...rest}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ exports[`Storyshots Inputs/AddressInput Simple Address Input 1`] = `
className="PrivateNotchedOutline-legendLabelled-101 PrivateNotchedOutline-legendNotched-102"
>
<span>
generic-select
Network
</span>
</legend>
</fieldset>
Expand Down
6 changes: 3 additions & 3 deletions tests/inputs/Select/__snapshots__/select.stories.storyshot
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ exports[`Storyshots Inputs/Select Disabled Select 1`] = `
className="PrivateNotchedOutline-legendLabelled-115"
>
<span>
error-select
Select Token
</span>
</legend>
</fieldset>
Expand Down Expand Up @@ -148,7 +148,7 @@ exports[`Storyshots Inputs/Select Error Select 1`] = `
className="PrivateNotchedOutline-legendLabelled-119"
>
<span>
error-select
Select Token
</span>
</legend>
</fieldset>
Expand Down Expand Up @@ -231,7 +231,7 @@ exports[`Storyshots Inputs/Select Simple Select 1`] = `
className="PrivateNotchedOutline-legendLabelled-123"
>
<span>
simple-select
Select Token
</span>
</legend>
</fieldset>
Expand Down

0 comments on commit c678149

Please sign in to comment.