Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : 로그인과 리프레쉬 토큰 발급 시 쿠키로 던지기 #133

Open
wants to merge 1 commit into
base: back
Choose a base branch
from
Open

fix : 로그인과 리프레쉬 토큰 발급 시 쿠키로 던지기 #133

wants to merge 1 commit into from

Conversation

gandi0330
Copy link
Contributor

@gandi0330 gandi0330 commented Jul 20, 2022 •
edited
Loading

📑 제목

fix : 로그인과 리프레쉬 토큰 발급 시 쿠키로 던지기

📎 관련 이슈

✔️ 셀프 체크리스트

최소 1명 이상의 assign을 받아야만 Merge 가능합니다.

  • Warning Message가 발생하지 않았나요?
  • Coding Convention을 준수했나요?
  • Test Code를 작성하였나요?

💬 작업 내용

구현 내용 및 작업 했던 내역

🚧 PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

🕰 실제 소요 시간

작업을 시작하기 부터 PR을 올리기 까지 소요된 시간입니다.

  • (1시간)

@gandi0330 gandi0330 added this to the API개발 milestone Jul 20, 2022
@gandi0330 gandi0330 requested review from lion1735 and Yeom-JinHo July 20, 2022 08:32
@gandi0330 gandi0330 self-assigned this Jul 20, 2022
@Yeom-JinHo
Copy link
Member

확인 완

@Yeom-JinHo Yeom-JinHo requested a review from jmlee9707 July 20, 2022 08:33
@Yeom-JinHo
Copy link
Member

쿠키에 setMaxage 지정해주면 어떨까? (가능하다면)
왜냐하면 httponly라 프론트단에서 날릴 방법이 없을꺼 같은데.. (찾아봐야함)

@Yeom-JinHo
Copy link
Member

path 지정도..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lion1735 lion1735 Awaiting requested review from lion1735

@Yeom-JinHo Yeom-JinHo Awaiting requested review from Yeom-JinHo

@jmlee9707 jmlee9707 Awaiting requested review from jmlee9707

Assignees

@gandi0330 gandi0330

Labels
backend
Projects
None yet
Milestone
API개발
Development

Successfully merging this pull request may close these issues.
2 participants
@gandi0330 @Yeom-JinHo