-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: #195 verbose and porcelain are a cli feature and not in core #210
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work.
Not your fault but I don't get why -v is a suboption of a command. Would have been better to have it as a global option.
Agree, i will move -v and -vv as a global config in this PR. |
+ add option trace
replace by a custom code that print if a test succeeded or not and print a summary
…throw an exception instead
Unit Test Results 60 files - 1 60 suites - 1 3m 43s ⏱️ +46s Results for commit a39846a. ± Comparison against base commit 9e94312. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
|
Verbose and trace (verbose ++) are a logger level, now every class can use it. Some log are modify, like normal mode print less (no config, summary print only executed script, …), driver print, trace can print shell command used for mongo cli and stdout of the command, …
porcelain is managed by cli module and not by core and other modules
Resolve #195