feat: open/close dl without self-defined reference count #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dl239
reviewed
Jul 26, 2023
dl239
reviewed
Jul 26, 2023
aceforeverd
reviewed
Jul 27, 2023
emo-coder
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3401 +/- ##
============================================
- Coverage 75.70% 75.68% -0.02%
Complexity 414 414
============================================
Files 700 701 +1
Lines 126668 126667 -1
Branches 1206 1206
============================================
- Hits 95888 95867 -21
- Misses 30539 30559 +20
Partials 241 241
☔ View full report in Codecov by Sentry. |
dl239
changed the title
dl239
approved these changes
Aug 7, 2023
aceforeverd
requested changes
Aug 7, 2023
| if (iter->second->ref_cnt == 0) { | ||
| so_handle = iter->second; | ||
| handle_map_.erase(iter); | ||
| if (iter->second != nullptr) { |
There was a problem hiding this comment.
a dynamic lib may be used by multi functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
CREATE FUNCTION: dlopen/dlclose not need to mutex lock handler #3378
What is the new behavior (if this is a feature change)?