Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disktable status #1788

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Leowner
Copy link
Contributor

@Leowner Leowner commented May 10, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Add SchedGC, GetRecordPkCnt and GetRecordIdxCnt in disktable

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label May 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022

SDK Test Report

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 56bdd39.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022

Linux Test Report

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 56bdd39.

♻️ This comment has been updated with latest results.

@zhanghaohit zhanghaohit changed the title [WIP] Feat/add disktable status feat: add disktable status May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Base: 75.60% // Head: 75.86% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (cafba7a) compared to base (26ba54c).
Patch coverage: 98.32% of modified lines in pull request are covered.

❗ Current head cafba7a differs from pull request most recent head 56bdd39. Consider uploading reports for the commit 56bdd39 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1788      +/-   ##
============================================
+ Coverage     75.60%   75.86%   +0.25%     
+ Complexity      392      354      -38     
============================================
  Files           644      619      -25     
  Lines        121346   117998    -3348     
  Branches       1060     1039      -21     
============================================
- Hits          91748    89523    -2225     
+ Misses        29361    28264    -1097     
+ Partials        237      211      -26     
Impacted Files Coverage Δ
src/storage/disk_table.h 72.56% <91.07%> (-15.52%) ⬇️
src/storage/disk_table.cc 87.47% <97.63%> (+6.03%) ⬆️
src/storage/disk_table_test.cc 99.78% <100.00%> (+<0.01%) ⬆️
src/storage/table_test.cc 99.76% <100.00%> (+0.46%) ⬆️
...java/com/_4paradigm/openmldb/sdk/SqlException.java 0.00% <0.00%> (-100.00%) ⬇️
src/storage/table.cc 70.73% <0.00%> (-16.27%) ⬇️
.../openmldb/batch/nodes/GroupByAggregationPlan.scala 73.80% <0.00%> (-11.91%) ⬇️
...n/java/com/_4paradigm/openmldb/jdbc/SQLDriver.java 50.72% <0.00%> (-11.19%) ⬇️
hybridse/include/sdk/base.h 19.23% <0.00%> (-10.40%) ⬇️
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhanghaohit
Copy link
Collaborator

check if there is ut to check: after gc, the data is actually deleted

@github-actions github-actions bot added api-server batch-engine openmldb batch(offline) engine build openmldb compiling and installing docker openmldb compile image or demo image documentation Improvements or additions to documentation execute-engine hybridse sql engine extensions airflow, kafaka extensions go-sdk monitoring openmldb prometheus exporter & mixin sdk openmldb java/python sdk task-manager openmldb taskmanager workflow CICD related and removed storage-engine openmldb storage engine. nameserver & tablet labels Oct 15, 2022
@Leowner Leowner force-pushed the feat/add_disk_status_from_main branch from 6188861 to cafba7a Compare October 15, 2022 15:49
@github-actions github-actions bot added storage-engine openmldb storage engine. nameserver & tablet and removed api-server docker openmldb compile image or demo image execute-engine hybridse sql engine task-manager openmldb taskmanager documentation Improvements or additions to documentation go-sdk sdk openmldb java/python sdk build openmldb compiling and installing monitoring openmldb prometheus exporter & mixin workflow CICD related batch-engine openmldb batch(offline) engine extensions airflow, kafaka extensions labels Oct 15, 2022
@tobegit3hub
Copy link
Collaborator

@Leowner could you update the code to resolve the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants