Add external canvas usage to RuntimeGamePixiRenderer #7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvervlad
changed the title
4ian
reviewed
Nov 28, 2024
| @@ -189,6 +189,120 @@ namespace gdjs { | |||
| gameCanvas.focus(); | |||
| } | |||
|
|
|||
| useCanvas(gameCanvas: HTMLCanvasElement): void { | |||
There was a problem hiding this comment.
There is a lot of copy from the createStandardCanvas function. Could you rework createStandardCanvas so that it's using useCanvas under the hood?
Also, the name is probably not showing this is an important operation enough, that just can't be redone a second time. So I think it should be called initializeForCanvas
There was a problem hiding this comment.
Thank you for review! I've refactored createStandardCanvas, renamed useCanvas, updated runtimegame.dispose() and added tests.
danvervlad
force-pushed
the
feature/add-use-custom-canvas
branch
2 times, most recently
from
8f2b5df
to
6febb37
Compare
danvervlad
changed the title
danvervlad
changed the title
danvervlad
force-pushed
the
feature/add-use-custom-canvas
branch
from
6febb37
to
2c2f94e
Compare
danvervlad
force-pushed
the
feature/add-use-custom-canvas
branch
from
6778bc9
to
f1bc74a
Compare
4ian
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the useCanvas method in the RuntimeGamePixiRenderer class, enabling developers to provide an external canvas for rendering instead of relying on the internally created one.