Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect member permission service #3957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mayorova
Copy link
Contributor

Fixing a bug introduced in #3929

The test was randomly failing with:

User can show #<Cinstances::CinstancePlanChangedEvent:0x00007fcf9c94d3d8> but should not
/opt/ci/workdir/test/test_helper.rb:68:in `assert_cannot'
/opt/ci/workdir/test/unit/abilities/provider_any_test.rb:50:in `block (2 levels) in <class:ProviderAnyTest>'

Because... why would a Cinstance ID be provided to a Services IDs list? 🙃

Obviously, the Cinstance ID may coincide with the service ID, causing a wrong behavior.

Copy link
Contributor

@akostadinov akostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy, this id matching in tests sometimes makes tests buggy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants