Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping service ports #304

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix mapping service ports #304

merged 2 commits into from
Aug 6, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Aug 6, 2024

  • Bumps release to v0.25.0
  • Fixes a missing port in mapping-service that is used for probes in staging and produciton, although not for service

/kind release
/kind bug
/kind documentation
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/release Categorizes issue or PR as related to a new release. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Aug 6, 2024
@3scale-robot 3scale-robot requested review from raelga and slopezz August 6, 2024 10:05
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Aug 6, 2024
@raelga
Copy link
Contributor

raelga commented Aug 6, 2024

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1f2695e21f5f1766e7c4ee0991d5cd8808335f2

@roivaz
Copy link
Member Author

roivaz commented Aug 6, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@3scale-robot 3scale-robot merged commit a10ed06 into main Aug 6, 2024
4 checks passed
@3scale-robot 3scale-robot deleted the fix-mapping-service-ports branch August 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. kind/release Categorizes issue or PR as related to a new release. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @raelga @3scale-robot