Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system-app Service name #303

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix system-app Service name #303

merged 1 commit into from
Jul 30, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jul 29, 2024

Small fix for local-setup after the publishing strategies API upgrade.

/kind bug
/priority important-longterm
/assign

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. labels Jul 29, 2024
@3scale-robot 3scale-robot requested review from raelga and slopezz July 29, 2024 15:21
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XS Requires less than an hour to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jul 29, 2024
@raelga
Copy link
Contributor

raelga commented Jul 29, 2024

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eefbf2fdf1574919612269994b2e005f1050c85c

@roivaz
Copy link
Member Author

roivaz commented Jul 30, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@3scale-robot 3scale-robot merged commit 7569ab6 into main Jul 30, 2024
3 of 4 checks passed
@3scale-robot 3scale-robot deleted the fix/local-setup branch July 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/XS Requires less than an hour to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants