Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dymanic external-secret generation #287

Merged
merged 8 commits into from
Jan 18, 2024
Merged

dymanic external-secret generation #287

merged 8 commits into from
Jan 18, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jan 9, 2024 •
edited
Loading

  • ExternalSecrets are now dynamically generated only when required. This is important to remove the dependency of saas dev environments from external-secrets operator and vault.
  • The owned resources of each controller are now automatically watched. Only when the baserecociler sees a new resource type being managed is the watch started. The idea is that if no external-secrets need to be generated, the controller should not watch the external-secrets API, removing the dependency and making it's installation optional.
  • Reworked the BuildEnvironment related functions to simplify it's usage. The new code also relies less on reflection, which makes the code less obscure.

I tested an alpha release in the staging environment and no changes were done on any of the current resources, which is what was expected.

/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot requested review from raelga and slopezz January 9, 2024 15:38
@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XL Requires about a week to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jan 9, 2024
@roivaz roivaz force-pushed the feature/dynamic-external-secrets-2 branch 9 times, most recently from 9e0a515 to 6918a91 Compare January 11, 2024 16:14
@roivaz
Rework options framework
fa99f9a 
ExternalSecrets are now dynamically generated only when required. This is important to
remove the dependency of saas dev environments from external-secrets
operator and vault.
@roivaz roivaz force-pushed the feature/dynamic-external-secrets-2 branch from 6918a91 to 201aa4b Compare January 11, 2024 16:55
@roivaz roivaz force-pushed the feature/dynamic-external-secrets-2 branch from 201aa4b to 009ce51 Compare January 16, 2024 10:43
@roivaz
Copy link
Member Author

roivaz commented Jan 16, 2024

/retitle dymanic external-secret generation

@3scale-robot 3scale-robot changed the title wip - dymanic external-secret generation dymanic external-secret generation Jan 16, 2024
@raelga
Copy link
Contributor

raelga commented Jan 18, 2024

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a7fa13f4977ab69dac1343040f985e0d5c2bc7f8

@3scale-robot 3scale-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@roivaz roivaz added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Jan 18, 2024
@3scale-robot 3scale-robot removed needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. labels Jan 18, 2024
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92f21023259a627231baf92009f0f63171bf571c

@roivaz
Copy link
Member Author

roivaz commented Jan 18, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@3scale-robot 3scale-robot merged commit 7e2a9ef into main Jan 18, 2024
5 checks passed
@3scale-robot 3scale-robot deleted the feature/dynamic-external-secrets-2 branch January 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@raelga raelga

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/XL Requires about a week to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roivaz @raelga @3scale-robot @slopezz