Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update users and right section #237

Merged
merged 2 commits into from
Oct 27, 2023
Merged

update users and right section #237

merged 2 commits into from
Oct 27, 2023

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Sep 22, 2023

No description provided.

@Gustry Gustry self-requested a review September 25, 2023 13:21
@nworr nworr marked this pull request as ready for review October 2, 2023 08:28
@nworr nworr requested a review from laurentj October 2, 2023 08:28
@Gustry Gustry mentioned this pull request Oct 9, 2023
Merged
@Gustry
Copy link
Member

Gustry commented Oct 9, 2023

I took your commits from this PR in #238
Just the example needs to be added, according to discussion on the chat.

@Gustry Gustry merged commit 292fcf3 into master Oct 27, 2023
@Gustry Gustry deleted the user-rigths-explanation branch October 27, 2023 09:20
@Gustry
Copy link
Member

Gustry commented Oct 27, 2023

How come GitHub merged this PR while I merged #238 ... GitHub only checked commits ID, while as I said in #238, I didn't backport the example...

@Gustry
Copy link
Member

Gustry commented Oct 27, 2023

Sorry @nworr I was interested by having an example, so I wanted to keep this PR open as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Awaiting requested review from Gustry

@laurentj laurentj Awaiting requested review from laurentj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nworr @Gustry