Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] AtlasPrint Listener not enough specific #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Nov 19, 2024

The cadastre atlas print listener was not enough specific.

To fix it, the cadastreConfig has been enhanced and the cadastre atlas print listener checks the config and uses the cadastre profile based on Parcelle layer.

Funded by Haute Saone Numérique

@rldhont rldhont requested a review from mdouchin November 19, 2024 23:06
The cadastre atlas print listener was not enough specific.

To fix it, the cadastreConfig has been enhanced and the cadastre atlas print listener checks the config and uses the cadastre profile based on Parcelle layer.

Funded by Haute Saone Numérique
@rldhont rldhont force-pushed the fix-atlasprint-listener branch from c029962 to 2cc0611 Compare November 19, 2024 23:09
Gustry

This comment was marked as duplicate.

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
Quick review for now

Comment on lines +24 to +31
if (version_compare($services->qgisServerVersion, '3.0', '<')) {
if (!preg_match('#^cadastre#i', $event->project)) {
return null;
}
$cadastreConfig = array(
'layer' => 'Parcelles',
'pk' => 'geo_parcelle',
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (version_compare($services->qgisServerVersion, '3.0', '<')) {
if (!preg_match('#^cadastre#i', $event->project)) {
return null;
}
$cadastreConfig = array(
'layer' => 'Parcelles',
'pk' => 'geo_parcelle',
);

If this code is for QGIS server < 3.0, this must be removed.

Related to #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants