Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string Templating for sql scripts #433

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Use string Templating for sql scripts #433

merged 1 commit into from
Jan 20, 2025

Conversation

dmarteau
Copy link
Member

Use string.Template for string substitution in sql scripts:

  • Almost universal basic templating format.
  • Raise error on unresolved placeholder: prevent creating invalid sql scripts.
  • A bit Less code to maintain.

Gustry
Gustry approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a Python point of view, LGTM, thanks

mdouchin
mdouchin approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I juste rebased this old PR on master, added the modifications to the 2024 file.

@mdouchin mdouchin merged commit 9a559ce into master Jan 20, 2025
6 checks passed
@mdouchin mdouchin deleted the fix-sql-templating branch January 20, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdouchin mdouchin mdouchin approved these changes

@Gustry Gustry Gustry approved these changes

@rldhont rldhont Awaiting requested review from rldhont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmarteau @Gustry @mdouchin