Class to function #77

saykaren · 2019-10-15T02:53:29Z

PR Checklist

Please check if your PR fulfills the following requirements:

[x ] The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ x] Code style update (formatting, local variables) - Changes class to a functional component
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

I am changing the code from class to a functional component with state
Issue Number: N/A

What is the new behavior?

Same behavior

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

… state to update properly once clicked. After you find two that don't match it crashes. Will look into more. Once I get it to functional component will be able to help with other code as I feel more comfortable with functional compoenents rather than classes

…state to remove other items. Now start new game is having issues.

… let statement

…k my formatting is off for the highscorelist

…e issue. The count for clicks and revealed cards seems to be one off. Will work more on it

bikkimahato · 2021-09-26T07:15:01Z

src/components/app.js

+        temporaryValue,
+        randomIndex;
+
+      while (0 !== currentIndex) {


Condition can only be like while (currentIndex)

bikkimahato · 2021-09-26T07:15:36Z

src/components/app.js

-      temporaryValue = cards[currentIndex];
-      cards[currentIndex] = cards[randomIndex];
-      cards[randomIndex] = temporaryValue;
+      console.log({state});


You can remove the logs.

bikkimahato · 2021-09-26T07:15:53Z

src/components/app.js

+        cardDeck[currentIndex] = cardDeck[randomIndex];
+        cardDeck[randomIndex] = temporaryValue;
+      }
+      console.log(`cards to be rerendered are ${cardDeck}`);


You can remove the logs.

bikkimahato · 2021-09-26T07:16:38Z

src/components/app.js

+      console.log({updateAccuracy});
+      console.log(`accuracy is ${accuracy}`);


You can remove the logs.

bikkimahato · 2021-09-26T07:16:51Z

src/components/app.js

+      //   ...state,
+      //   accuracy : fakeAccuracy
+      // });
+      console.log(`in accuracy`);


You can remove the logs.

bikkimahato · 2021-09-26T07:17:01Z

src/components/app.js

+      console.log(`userAttempts are ${userAttempts} num possible is ${numPossibleCorrect}`);
+      console.log({updateAccuracyRate});


You can remove the logs.

bikkimahato · 2021-09-26T07:17:34Z

src/components/app.js

+
+      //adds how many active cards flipped there are
+      newRevealStates.forEach(function(el) {
+        if (el === true) {


You can just keep the condition to be if (el)

bikkimahato · 2021-09-26T07:17:46Z

src/components/app.js

+
+      newRevealStates[index] = true;
+
+      console.log({newRevealStates});


You can remove the logs.

bikkimahato · 2021-09-26T07:18:06Z

src/components/app.js

-      this.hideCards(() => {
-        this.updateAccuracy();
+      hideCards(() => {
+        console.log(`where I want to be`);


You can remove the logs.

Karen Garcia added 7 commits October 3, 2019 15:48

got it to work, had to add ...state as the setState was changing the …

a442ccc

…state to remove other items. Now start new game is having issues.

got cards to change. Moved cards to a state of cardDeck rather than a…

9701f24

… let statement

having issues with highScores, causing issues to start new game. Thin…

3d6bf81

…k my formatting is off for the highscorelist

working on updateAccuracy, not working properly

c251df3

able to add newGame right, was missing one item on state which was th…

454334a

…e issue. The count for clicks and revealed cards seems to be one off. Will work more on it

still working on it

951bf26

bikkimahato reviewed Sep 26, 2021

View reviewed changes

src/components/app.js

temporaryValue,

randomIndex;

while (0 !== currentIndex) {

Copy link

bikkimahato Sep 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Condition can only be like while (currentIndex)

bikkimahato reviewed Sep 26, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Class to function #77

Class to function #77

saykaren commented Oct 15, 2019

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

bikkimahato Sep 26, 2021

		console.log({updateAccuracy});
		console.log(`accuracy is ${accuracy}`);

		console.log(`userAttempts are ${userAttempts} num possible is ${numPossibleCorrect}`);
		console.log({updateAccuracyRate});


		newRevealStates[index] = true;

		console.log({newRevealStates});

Class to function #77

Are you sure you want to change the base?

Class to function #77

Conversation

saykaren commented Oct 15, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment