Trianglesets

[gangatp]

Rebased the old branch with new develop. Targeting for the next release.

This is the release of the core spec
https://github.com/3MFConsortium/spec_core/releases/tag/1.3.0

• ToDo
• Add unit tests
• Add examples

[codecov]

Codecov Report

Attention: Patch coverage is 57.61317% with 412 lines in your changes missing coverage. Please review.

Project coverage is 65.91%. Comparing base (905c367) to head (f8f4d75).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
Autogenerated/Source/lib3mf_interfacewrapper.cpp	44.05%	306 Missing ⚠️
Source/API/lib3mf_triangleset.cpp	51.25%	39 Missing ⚠️
Source/Model/Classes/NMR_ModelTriangleSet.cpp	46.34%	22 Missing ⚠️
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp	86.84%	10 Missing ⚠️
Source/Common/NMR_Exception.cpp	0.00%	9 Missing ⚠️
Source/Model/Classes/NMR_ModelMeshObject.cpp	84.78%	7 Missing ⚠️
Source/API/lib3mf_meshobject.cpp	84.61%	4 Missing ⚠️
...Model/Writer/v100/NMR_ModelWriterNode100_Model.cpp	60.00%	4 Missing ⚠️
...der/v100/NMR_ModelReaderNode100_TriangleSetRef.cpp	86.36%	3 Missing ⚠️
...eader/v100/NMR_ModelReaderNode100_TriangleSets.cpp	88.00%	3 Missing ⚠️
... and 4 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #404      +/-   ##
===========================================
- Coverage    66.09%   65.91%   -0.19%     
===========================================
  Files          395      400       +5     
  Lines        44642    45611     +969     
===========================================
+ Hits         29506    30063     +557     
- Misses       15136    15548     +412     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[3dJan]

There are not tests yet, that makes it hard to check if the implementation matches the spec.

[gangatp]

There are not tests yet, that makes it hard to check if the implementation matches the spec.

Hi Jan, thanks for reviewing. I will add unit test and examples to this PR.

[vijaiaeroastro]

@gangatp Once unit tests are available and verified to work as expected, it will be easier to review whether the PR works. We can then follow a similar strategy as implicit and proceed with the merge. We can do examples after the merge is complete.

[gangatp]

Hi Team, I added a basic unit test to check the functionality.

[vijaiaeroastro]

Checked the unit tests. Seems to work fine. Coverage keeps failing. But I guess that's expected.

[vijaiaeroastro]

We can add something very similar to the unit test as an example once this is merged.

[gangatp]

I will do a follow up PR to fix the code coverage.