Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Lib3MF dependent libraries #336

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

gangatp
Copy link
Collaborator

@gangatp gangatp commented Dec 19, 2023

updated third party libraries are:

  • fast_float v6.0.0
  • zlib v1.3
  • cpp-base64 v2.rc.08
  • libzip v1.10.1
  • googletest v1.14.0
  • LibreSSL v3.8.2

Except LibreSSL all other libraries can be updated by updating the submodule pointer and running the update_libs script.
For LibreSSL download the library from https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/ and manually copy it to libraries.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (465c0da) 69.74% compared to head (991caed) 69.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #336      +/-   ##
===========================================
- Coverage    69.74%   69.19%   -0.55%     
===========================================
  Files          271      271              
  Lines        29758    28688    -1070     
===========================================
- Hits         20755    19851     -904     
+ Misses        9003     8837     -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gangatp
Copy link
Collaborator Author

gangatp commented Dec 19, 2023

The codecoverage results are bit ambiguous. There is a 0.5% drop in code coverage without any direct file changes. In the previous run without the update of LibreSSL the code coverage is #335 69.75%. I have updated the LibreSSL library to new version and that should not impact on code coverage at all. So testing both of this commit points locally (before updating LibreSSL and after updating LibreSSL), before updating LibreSSL :

image

After updating LibreSSL:
image

So the files showing indirect changes in codecov should not be affected by this commit. This commit is safe to be merged.

@gangatp gangatp changed the title Updating LibReSSL Updating Lib3MF dependent libraries Jan 9, 2024
@gangatp gangatp merged commit e77162c into 3MFConsortium:develop Jan 9, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants