-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Lib3MF dependent libraries #336
Updating Lib3MF dependent libraries #336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #336 +/- ##
===========================================
- Coverage 69.74% 69.19% -0.55%
===========================================
Files 271 271
Lines 29758 28688 -1070
===========================================
- Hits 20755 19851 -904
+ Misses 9003 8837 -166 ☔ View full report in Codecov by Sentry. |
The codecoverage results are bit ambiguous. There is a 0.5% drop in code coverage without any direct file changes. In the previous run without the update of LibreSSL the code coverage is #335 69.75%. I have updated the LibreSSL library to new version and that should not impact on code coverage at all. So testing both of this commit points locally (before updating LibreSSL and after updating LibreSSL), before updating LibreSSL : So the files showing indirect changes in codecov should not be affected by this commit. This commit is safe to be merged. |
updated third party libraries are:
Except LibreSSL all other libraries can be updated by updating the submodule pointer and running the update_libs script.
For LibreSSL download the library from https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/ and manually copy it to libraries.