4.3.121

Changes for 4.3.121

Changes to branch 4.3 after version 4.3.120.

Commits

• Add .vscode directory to .gitignore. - by Roger Neate

  Visual Studio Code uses the .vscode directory for workspace settings that should not be under source control.

• acdc - PISTON-1112: fix validation of agent pause timeout/time-limit - by Daniel Finke

  • schema validates system_config.acdc default_agent_pause_timeout for non-negative integers or the "infinity" special string

  • refactored out ?DEFAULT_AGENT_PAUSE_TIMEOUT into shared header

  • fixed acdc_maintenance expecting integer, despite possibility of <<"infinity">> value

  • moved Time-Limit validation in kapi_acdc_agent into PAUSE_* macros rather than AGENT_*

• SUPP-16: load_parents sets an empty object for account - by Hesaam Farhang

  It is not clear what is the difference between /accounts/:id/parents and

  /accounts/:id/tree. But the are doing same thing in different ways.

  As it turns out load_parents is loading all result of accounts/listing_by_id

  and then uses kz_json:find_value/3 to grab the parent's account info.

  But it is constantly failing in a specific server. I can't reproduce the exact

  problem in any environment that I test it.

  For example it should return:

  [{"id":"{ACCOUNT_1}","name":"{ACCOUNT1_NAME}"},{"id":"{ACCOUNT_2}","name":"{ACCOUNT2_NAME}"}]
  

  But it returns instead:

  [{"id":"{ACCOUNT_1}","name":"{ACCOUNT1_NAME}"},{}]
  

  Since those /tree and /parents seems returning same thing

  and /tree implementation is way more efficient and stable than /parents

  I change it to use that.

• HELP-6670: match smtp option on teletype, specifically no_mx_lookups - by Karl Anderson

• SUPP-22: do not normalize number if there is no dialplan or capture group - by Hesaam Farhang

  Do not normalize number if there is no dialplan or number is not from capture group when callflow wins the call.

  Normalizing twice may result the number to be classified differently so call won't be restricted.

• PROD-157: Seperate telemetry consensus logic - by John White

  This PR modifies how kazoo_telemetry determines its leader and removes functionality from kz_nodes.

  Changes:

  • backports change to kz_nodes to use node_info binding to retrieve metadata for node_info status

  • consensus logic moved to kazoo_telemetry_leader

  • kazoo_telemetry_leader now uses node_info binding to publish leader data

  • fixes bug where registration metadata wasn't being from registrar role in #kz_node{} record

• PROD-167: capture the subject line in inbound email to fax for use in notifications - by swysor

  After an upgrade to a release containing this enhancement, from one server running the teletype app by running the command:

  sup teletype_maintenance restore_system_templates

  This command will add the {{ subject }} macro used in templates and update the default templates in the database.