Better rev up, better amp shot, more buttons for zach #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EchoNotation
approved these changes
May 2, 2024
| if (speed < targetSpeed + revUpEn){ | ||
| double difference = targetSpeed - speed; | ||
| SmartDashboard.putNumber("SHOOTER/desired speed difference", difference); | ||
| if (difference>revUpEn){ | ||
| revState = 1; |
There was a problem hiding this comment.
Having this revstate variable be an integer is acceptable here-- especially since there is an obvious connection between the sign of revstate and the motor behavior. However, whenever you're implementing some logic that should only take certain states, it's a good idea to use an enum. https://www.w3schools.com/java/java_enums.asp Using an enum could improve readability (e.g. revState = RevState.REVVING_UP or revState = RevState.IDLE), but more importantly can prevent bugs like accidently setting revState to 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.