[refactor] contents 기초 코드 수정 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssunnykku
requested review from
rhaehf,
K-0joo,
pie2457,
jw427 and
jeongeungyeong
Open
4 tasks
Content: NoArgsConstructor AccessLevel 설정 User: user_id 컬럼명 변경
jw427
approved these changes
Aug 23, 2024
pie2457
reviewed
Aug 23, 2024
| private String title; | ||
|
|
There was a problem hiding this comment.
37라인부터 43라인까지 공백은 없어도 괜찮은거 같아요 ~!
| public class User { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.UUID) | ||
| @Column(name = "userId", nullable = false) | ||
| @Column(name = "user_Id", nullable = false) |
There was a problem hiding this comment.
user_Id -> user_id가 맞을 것 같습니다!
| @EntityListeners(AuditingEntityListener.class) | ||
| public class Content { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.SEQUENCE) | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "content_id", nullable = false) |
There was a problem hiding this comment.
테이블의 pk를 content_id라고 설정해 놓으셨나요? id라고 설정해 놓으셨으면 name은 따로 작성 안하셔도 돼요!
There was a problem hiding this comment.
네 DB 모델링 할 때 content_id로 했었습니다.
| @Column(name = "content_id", nullable = false) | ||
| private Long id; | ||
|
|
||
| @Column(name = "like_count") |
There was a problem hiding this comment.
카멜 케이스는 알아서 스네이크 케이스로 변경되기 때문에 어노테이션 따로 작성 안하셔도 괜찮습니다!
pie2457
approved these changes
Aug 23, 2024
rhaehf
reviewed
Aug 23, 2024
| @Table(name="contents") | ||
| @NoArgsConstructor | ||
| @Table(name = "contents") | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) |
There was a problem hiding this comment.
이전 PR에서 제안한 의견 반영해 주신거 확인했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR 타입(하나 이상의 PR 타입을 선택해주세요)
반영 브랜치
feat/contents_entity -> dev
변경 사항
코드 리뷰 반영하여 코드 수정