-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SC-1037] VelodromeV2 #109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 80.34% 81.28% +0.94%
==========================================
Files 31 32 +1
Lines 814 855 +41
Branches 171 178 +7
==========================================
+ Hits 654 695 +41
Misses 160 160 ☔ View full report in Codecov by Sentry. |
Co-authored-by: zZoMROT <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be great to discuss the possibility of separating duplicated code into a new function and its impact on the overall code readability.
# Conflicts: # package.json # yarn.lock
To do before merging:
secrets.OPTIMISTIC_RPC_URL
secrets.MAINNET_RPC_URL
tosecrets.MAINNET_RPC_URL|secrets.RPC_AUTH_HEADER