Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1037] VelodromeV2 #109

Merged
merged 11 commits into from
Jan 31, 2024
Merged

[SC-1037] VelodromeV2 #109

merged 11 commits into from
Jan 31, 2024

Conversation

zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Jan 30, 2024

To do before merging:

  • add secrets.OPTIMISTIC_RPC_URL
  • change secrets.MAINNET_RPC_URL to secrets.MAINNET_RPC_URL|secrets.RPC_AUTH_HEADER
  • resolve conversations

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad91d90) 80.34% compared to head (2ce2222) 81.28%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   80.34%   81.28%   +0.94%     
==========================================
  Files          31       32       +1     
  Lines         814      855      +41     
  Branches      171      178       +7     
==========================================
+ Hits          654      695      +41     
  Misses        160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: zZoMROT <[email protected]>
Copy link
Contributor

@byshape byshape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great to discuss the possibility of separating duplicated code into a new function and its impact on the overall code readability.

contracts/oracles/VelodromeV2Oracle.sol Show resolved Hide resolved
contracts/oracles/VelodromeV2Oracle.sol Outdated Show resolved Hide resolved
@zZoMROT zZoMROT requested a review from byshape January 30, 2024 14:38
@zZoMROT zZoMROT merged commit 6ce8fb4 into master Jan 31, 2024
5 of 7 checks passed
@zZoMROT zZoMROT deleted the feature/velodrome-v2 branch January 31, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants