Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-1198] Upgrade FeeTaker #342

Merged
merged 17 commits into from
Dec 10, 2024
Merged

[SC-1198] Upgrade FeeTaker #342

merged 17 commits into from
Dec 10, 2024

Conversation

ZumZoom
Copy link
Member

@ZumZoom ZumZoom commented Nov 19, 2024 •
edited
Loading

  • Getters are split to multiple classes. The idea is that each new getter calls super and adds some extra multiplication overhead
  • FeeTaker checks that taker is either in whitelist or has AccessToken
  • _parseFeeData is universal for getters and postInteraction
  • _isWhitelisted is virtual to allow for different whitelist structure in getters and postInteraction
  • postInteraction now allows custom chained calls to other post-interactions

@ZumZoom ZumZoom changed the title Upgrade FeeTaker [SC-1198] Upgrade FeeTaker Nov 21, 2024
@ZumZoom @byshape
add natspec
994e529 
Co-authored-by: Xenia <[email protected]>
@ZumZoom ZumZoom merged commit c5e3424 into master Dec 10, 2024
5 checks passed
@ZumZoom ZumZoom deleted the feature/fee-taker-upgrade branch December 10, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byshape byshape byshape approved these changes

@zZoMROT zZoMROT zZoMROT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZumZoom @zZoMROT @byshape