chore: add some todo's

1inch · Oct 19, 2023 · d4e27f8 · d4e27f8
1 parent 490729b
commit d4e27f8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/test/LimitOrderProtocol.js b/test/LimitOrderProtocol.js
@@ -1021,8 +1021,8 @@ describe('LimitOrderProtocol', function () {
             expect(await swap.remainingInvalidatorForOrder(addr1.address, '0x0000000000000000000000000000000000000000000000000000000000000001')).to.equal('0');
         });
 
+        // TODO: fix simulate test
         it('can simulate order cancelation', async function () {
-            // TODO: prepare more representative test in 'wip' section - illustrate cases when SimulationResults args is different from 0x
             const { swap, order } = await loadFixture(orderCancelationInit);
 
             const calldata = swap.interface.encodeFunctionData('cancelOrder', [

diff --git a/test/helpers/orderUtils.js b/test/helpers/orderUtils.js
@@ -46,6 +46,10 @@ const TakerTraitsConstants = {
     _ARGS_INTERACTION_LENGTH_MASK: 0xffffff,
 };
 
+// TODO: reaname minReturn to threshold
+// if makingAmount flag set to false, it works as minReturn (in making asset)
+// if makingAmount flag set true, it works as maxSpent (in taking asset)
+// TODO: also adjust description.md
 function buildTakerTraits ({
     makingAmount = false,
     unwrapWeth = false,