better price formatting

1delta-DAO · Jan 30, 2024 · e5327ce · e5327ce
1 parent 2b200ad
commit e5327ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/frontend/src/app/components/positions-table/index.tsx b/frontend/src/app/components/positions-table/index.tsx
@@ -20,7 +20,6 @@ interface RowProps {
 const Row = ({ position, market }: RowProps) => {
   const { closePosition } = useManagePosition({ marketAddress: market.address })
 
-  const price = formatWithDecimals(position.price, 6)
   const positionPnlPercentage = formatPercentage(parseInt(position.pnlPercentage))
 
   const longShortcolor = position.isLong ? 'text-green-500' : 'text-red-500'
@@ -31,7 +30,9 @@ const Row = ({ position, market }: RowProps) => {
   const positionNetValue = collateralUsd + collateralUsd * (parseInt(position.pnlPercentage) / 100)
   const pnlUsd = positionNetValue - collateralUsd
   const size = collateralAmount * parseInt(position.leverage)
+
   const entryPrice = formatWithDecimals(position.entryPrice, 6)
+  const marketPrice = formatWithDecimals(position.price, 6)
   const liquidationPrice = formatWithDecimals(position.liquidationPrice, 6)
 
   const handleClosePosition = async () => {
@@ -81,11 +82,11 @@ const Row = ({ position, market }: RowProps) => {
         </div>
       </td>
 
-      <td>{formatDollarAmount(entryPrice)}</td>
+      <td>{formatDollarAmount(entryPrice, 4)}</td>
 
-      <td>{formatDollarAmount(price)}</td>
+      <td>{formatDollarAmount(marketPrice, 4)}</td>
 
-      <td>{formatDollarAmount(liquidationPrice)}</td>
+      <td>{formatDollarAmount(liquidationPrice, 4)}</td>
 
       <td>
         <Button

diff --git a/frontend/src/utils/formatters.ts b/frontend/src/utils/formatters.ts
@@ -1,5 +1,5 @@
-export const formatNumber = (number: number) => {
-  return number.toLocaleString(undefined, { maximumFractionDigits: 2 })
+export const formatNumber = (number: number, precision = 2) => {
+  return number.toLocaleString(undefined, { maximumFractionDigits: precision })
 }
 
 export const formatPercentage = (percentage: number) => {
@@ -10,8 +10,8 @@ export const formatPercentage = (percentage: number) => {
     : `-${percentageFormattedWithoutSign}%`
 }
 
-export const formatDollarAmount = (amount: number) => {
-  return `$${formatNumber(amount)}`
+export const formatDollarAmount = (amount: number, precision = 2) => {
+  return `$${formatNumber(amount, precision)}`
 }
 
 export const formatDollarAmountWithSign = (amount: number) => {