Merge pull request #87 from mjpieters/use_httpx_for_json

Leave JSON encoding to HTTPX
1Password · Jan 5, 2024 · a741a44 · a741a44
2 parents bf1c6fa + dc5e390
commit a741a44
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/onepasswordconnectsdk/async_client.py b/src/onepasswordconnectsdk/async_client.py
@@ -1,7 +1,6 @@
 """Python AsyncClient for connecting to 1Password Connect"""
 import httpx
 from httpx import HTTPError
-import json
 from typing import Dict, List, Union
 import os
 
@@ -361,8 +360,8 @@ def build_request(self, method: str, path: str, body=None) -> httpx.Response:
         """
 
         if body:
-            serialized_body = json.dumps(self.serializer.sanitize_for_serialization(body))
-            response = self.session.request(method, path, data=serialized_body)
+            sanitized_body = self.serializer.sanitize_for_serialization(body)
+            response = self.session.request(method, path, json=sanitized_body)
         else:
             response = self.session.request(method, path)
         return response

diff --git a/src/onepasswordconnectsdk/client.py b/src/onepasswordconnectsdk/client.py
@@ -368,8 +368,8 @@ def build_request(self, method: str, path: str, body=None) -> httpx.Response:
         """
 
         if body:
-            serialized_body = json.dumps(self.serializer.sanitize_for_serialization(body))
-            response = self.session.request(method, path, data=serialized_body)
+            sanitized_body = self.serializer.sanitize_for_serialization(body)
+            response = self.session.request(method, path, json=sanitized_body)
         else:
             response = self.session.request(method, path)
         return response