Remove useActions from many screens #634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Harthor is attempting to deploy a commit to the 1hive Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/1hive/honey-pot/CPeFU6qXAcPEuLXvXqD5KRBf5t5E |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We worked on this issue with @juliangnr90
We removed useActions from 8 screens.
On each screen we receive only the necessary actions for the screen through props.
The only one we didn't remove is createProposalScreen because this is called from Home and Footer, with Home it's ok because it's already calling useActions, the problem is the footer component, which is called from MainView component and we are not sure which is the best way to call actions from that component.
We tested it for:
RaiseDisputeScreens
RemoveProposalScreens
SignAgreementScreens
SupportProposalScreens
WrapTokenScreens
We will be able to test these in the next 48 hours I think, we left a proposal challenged and a proposal supported in the test dao.
ExecuteProposalScreens
SettleProposalScreens
We don't know about ClaimRewardsScreens