Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15155: Logging when user visits connected accounts page #11554

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jmdembe
Copy link
Contributor

@jmdembe jmdembe commented Nov 25, 2024

🎫 Ticket

LG-15155

🛠 Summary of changes

This is a bug ticket.
This adds a logging event for when users visit the connected accounts page

📜 Testing Plan

Required

  • An existing account with an associated service provider
  • make watch_events is running in the background

Before:

  • Sign in as user with SP already associated with account
  • Go to accounts page
  • Click on your connected accounts link
  • Land on connected accounts page

Current behavior: visiting the connected accounts page would not be logged

Expected behavior: once visited, the connected_accounts_page_visited event will be shown in the console.

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some test coverage please?

@jmdembe
Copy link
Contributor Author

jmdembe commented Nov 25, 2024

Can we add some test coverage please?

Yes, I forgot to put this PR in draft status

changelog: Internal, logging bugfix, add logging event for connected accounts page visit
@jmdembe jmdembe force-pushed the jd-LG-15155-connected-accounts-analytics branch from bfc0aa0 to 17dc025 Compare November 25, 2024 19:37
@jmdembe jmdembe force-pushed the jd-LG-15155-connected-accounts-analytics branch from 2869f25 to 196ca28 Compare November 26, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants