-
Notifications
You must be signed in to change notification settings - Fork 137
WIP: Creating a Python package #231
base: master
Are you sure you want to change the base?
Conversation
setup.py
Outdated
|
||
# Author details | ||
author='GSA 18F', | ||
# TODO: What is the right email -- author_email='[email protected]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konklone -- do you know the right email for here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't! But maybe we can just start with [email protected] for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that was one thought I'd had.
This actually appears to be working now as is, but I'm going to use this as an excuse to roll this into a proper package structure while I'm touching it. |
FYI -- There is now an (early, WIP) version of the package uploaded at: https://pypi.org/project/domain-scan/ You should be able to now: > scan --help
Traceback (most recent call last):
File "/Users/lee1001/.virtualenvs/python3/bin/scan", line 19, in <module>
from scanners.headless.local_bridge import headless_scan
ModuleNotFoundError: No module named 'scanners' |
@IanLee1521 This is great progress. Thank you for working on this! Also, @jsf9k and I just maybe-simplified or maybe-complicated this work, by splitting out the requirements into different places in #224. In a I don't think we yet have a live downstream use case of the |
I think we could keep the requirements split up by adding This is what I've done with the testing requirements in I also modified |
TODO: