Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added date tests to basic-querying to ensure client encoding is applied ... #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wwoods
Copy link

@wwoods wwoods commented Sep 27, 2013

...to queries as well as data. At least the client driver for rethinkdb was exhibiting broken behavior when dates were queried, even though all tests were passing previously.

@1602
Copy link
Owner

1602 commented Sep 27, 2013

This test cases specific to sql (and other adapter supporting 'lt' operator) right? Would be great to test it separately and not in basic querying section.

@wwoods
Copy link
Author

wwoods commented Sep 27, 2013

Ah, didn't think about some adapters not supporting lt. Where would you recommend it be set up..? I'm not too familiar with the jugglingdb code, if you point me in the right direction I'd be happy to fix up this request to be friendly to drivers without lt support.

@anatoliychakkaev
Copy link
Collaborator

Redis adapter doesn't support that feature. Just use separate file named
something.test.js with your test case, please make sure memory adapter pass
this test. Next step will be: include this test in all adapters that
support that feature (lt).

On Fri, Sep 27, 2013 at 5:17 PM, Walt Woods [email protected]:

Ah, didn't think about some adapters not supporting lt. Where would you
recommend it be set up..? I'm not too familiar with the jugglingdb code, if
you point me in the right direction I'd be happy to fix up this request to
be friendly to drivers without lt support.


Reply to this email directly or view it on GitHubhttps://github.com//pull/328#issuecomment-25257406
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants