Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reuse audio context, no audio when using krisp in some cases #3379

Merged
merged 13 commits into from
Dec 26, 2024
Merged

fix: reuse audio context, no audio when using krisp in some cases #3379

merged 13 commits into from
Dec 26, 2024

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Nov 19, 2024 •
edited
Loading

Description

https://app.devrev.ai/100ms/works/ISS-30684

Use existing audio context in plugins manager

Pre-launch Checklist

  • I updated/added relevant documentation.
  • The Documentation is updated accordingly, or this PR doesn't require it.
  • All existing and new tests are passing.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.

Merging:

  • Squash merge to dev
  • Merge commit to publish-alpha and main

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 6:17am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 6:17am

@KaustubhKumar05 KaustubhKumar05 changed the title Fix/iss 30684 reuse audio context fix: reuse audio context Nov 19, 2024
@raviteja83 raviteja83 marked this pull request as ready for review December 23, 2024 09:32
@raviteja83 raviteja83 changed the title fix: reuse audio context fix: reuse audio context, no audio when using krisp in some cases Dec 26, 2024
@raviteja83 raviteja83 merged commit acd0a1f into dev Dec 26, 2024
4 checks passed
@raviteja83 raviteja83 deleted the fix/ISS-30684-reuse-audio-context branch December 26, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviteja83 raviteja83 raviteja83 approved these changes

@ygit ygit Awaiting requested review from ygit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaustubhKumar05 @raviteja83