Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add connection details in stats for nerds #3305

Merged
merged 15 commits into from
Oct 8, 2024
Merged

feat: add connection details in stats for nerds #3305

merged 15 commits into from
Oct 8, 2024

Conversation

hdz-666
Copy link
Collaborator

@hdz-666 hdz-666 commented Oct 7, 2024 •
edited
Loading

Details(context, link the issue, how was the bug fixed, what does the new feature do)

image
  • Updated sdk and hmsSdkactions also updated interface to have call details
  • Rendered new call details accordion on stats for nerds modal
  • added a height for stats for nerds to handle overflow

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:49am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:49am

@hdz-666 hdz-666 changed the base branch from main to dev October 7, 2024 11:49
@KaustubhKumar05
Copy link
Collaborator

KaustubhKumar05 commented Oct 7, 2024 •
edited
Loading

@hdz-666 can you cherry-pick and create a new branch from dev? ConnectionDetails might be a better name

@KaustubhKumar05 KaustubhKumar05 mentioned this pull request Oct 7, 2024
Closed
@KaustubhKumar05 KaustubhKumar05 changed the title fix: remove component feat: add connection details in stats for nerds Oct 7, 2024
@hdz-666 hdz-666 marked this pull request as ready for review October 7, 2024 12:18
KaustubhKumar05
KaustubhKumar05 previously approved these changes Oct 7, 2024
View reviewed changes
KaustubhKumar05
KaustubhKumar05 previously approved these changes Oct 7, 2024
View reviewed changes
KaustubhKumar05
KaustubhKumar05 previously approved these changes Oct 8, 2024
View reviewed changes
ygit
ygit approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raviteja83 raviteja83 merged commit 6239e8a into dev Oct 8, 2024
4 checks passed
@raviteja83 raviteja83 deleted the feat/WEB-2998-websocket-url-and-stats branch October 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygit ygit ygit approved these changes

@raviteja83 raviteja83 raviteja83 approved these changes

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 left review comments

@eswarclynn eswarclynn Awaiting requested review from eswarclynn

@amar-1995 amar-1995 Awaiting requested review from amar-1995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hdz-666 @KaustubhKumar05 @raviteja83 @ygit