Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check for role change in plugins #2749

Merged
merged 7 commits into from
Mar 26, 2024
Merged

fix: null check for role change in plugins #2749

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69f9ce9
fix: null check for role change in plugins
amar-1995 Mar 26, 2024
5f3496b
Merge branch 'dev' into WEB-2652-null-check-role-change-to-plugins
raviteja83 Mar 26, 2024
5a5e614
fix: added logs
amar-1995 Mar 26, 2024
e7598cf
Merge branch 'dev' into WEB-2652-null-check-role-change-to-plugins
amar-1995 Mar 26, 2024
fd0d9f6
fix: merge with dev
amar-1995 Mar 26, 2024
2a187c1
Merge branch 'WEB-2652-null-check-role-change-to-plugins' of github.c…
amar-1995 Mar 26, 2024
cf0b9f2
fix: update comment
raviteja83 Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/hms-video-store/src/sdk/store/Store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ import {
HMSVideoTrack,
} from '../../media/tracks';
import { PolicyParams } from '../../notification-manager';
import HMSLogger from '../../utils/logger';
import { ENV } from '../../utils/support';
import { createUserAgent } from '../../utils/user-agent';
import HMSRoom from '../models/HMSRoom';
import { HMSLocalPeer, HMSPeer, HMSRemotePeer } from '../models/peer';

class Store {
private TAG = '[Store]:';
private room?: HMSRoom;
private knownRoles: KnownRoles = {};
private localPeerId?: string;
Expand Down Expand Up @@ -415,6 +417,10 @@ class Store {
pluginName: keyof PolicyParams['plugins'],
permission: HMSPermissionType,
) => {
if (!this.knownRoles[role]) {
HMSLogger.d(this.TAG, `role ${role} is not present in given roles`, this.knownRoles);
return;
raviteja83 marked this conversation as resolved.
Show resolved Hide resolved
}
const rolePermissions = this.knownRoles[role].permissions;
if (!rolePermissions[pluginName]) {
rolePermissions[pluginName] = [];
Expand Down
Loading