fix: clean up mediastream plugins (#3287)

100mslive · Oct 8, 2024 · 75e9ead · 75e9ead
1 parent 2b88485
commit 75e9ead
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/hms-video-store/src/media/tracks/HMSLocalVideoTrack.ts b/packages/hms-video-store/src/media/tracks/HMSLocalVideoTrack.ts
@@ -262,9 +262,11 @@ export class HMSLocalVideoTrack extends HMSVideoTrack {
    */
   async cleanup() {
     this.removeTrackEventListeners(this.nativeTrack);
+    // Stopping the plugin before cleaning the track is more predictable when dealing with 3rd party plugins
+    await this.mediaStreamPluginsManager.cleanup();
+    await this.pluginsManager.cleanup();
     super.cleanup();
     this.transceiver = undefined;
-    await this.pluginsManager.cleanup();
     this.processedTrack?.stop();
     this.isPublished = false;
     if (isBrowser && isMobile()) {

diff --git a/packages/hms-video-store/src/plugins/video/HMSMediaStreamPluginsManager.ts b/packages/hms-video-store/src/plugins/video/HMSMediaStreamPluginsManager.ts
@@ -63,4 +63,8 @@ export class HMSMediaStreamPluginsManager {
   getPlugins(): string[] {
     return Array.from(this.plugins).map(plugin => plugin.getName());
   }
+
+  async cleanup() {
+    this.removePlugins(Array.from(this.plugins));
+  }
 }