Skip to content

Commit

Permalink
fix: conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
KaustubhKumar05 committed Mar 21, 2024
2 parents cc984a3 + ca4de5f commit 517e096
Show file tree
Hide file tree
Showing 12 changed files with 38 additions and 22 deletions.
7 changes: 4 additions & 3 deletions packages/hms-video-store/src/transport/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -497,9 +497,10 @@ export default class HMSTransport {
this.joinParameters = undefined;
HMSLogger.d(TAG, 'leaving in transport');
try {
this.eventBus.analytics.publish(
AnalyticsEventFactory.getKrispUsage(this.pluginUsageTracker.getPluginUsage('HMSKrispPlugin')!),
);
const usage = this.pluginUsageTracker.getPluginUsage('HMSKrispPlugin');
if (usage) {
this.eventBus.analytics.publish(AnalyticsEventFactory.getKrispUsage(usage));
}
this.state = TransportState.Leaving;
this.publishStatsAnalytics?.stop();
this.subscribeStatsAnalytics?.stop();
Expand Down
2 changes: 1 addition & 1 deletion packages/roomkit-react/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { ReactNode, useCallback, useEffect, useRef, useState } from 'reac
import { useMedia } from 'react-use';
import data from '@emoji-mart/data';
import Picker from '@emoji-mart/react';
import { HMSException, selectLocalPeer, useHMSActions, useHMSStore } from '@100mslive/react-sdk';
import { HMSException, selectLocalPeer, useAVToggle, useHMSActions, useHMSStore } from '@100mslive/react-sdk';
import { EmojiIcon, PauseCircleIcon, SendIcon, VerticalMenuIcon } from '@100mslive/react-icons';
import { Box, config as cssConfig, Flex, IconButton as BaseIconButton, Popover, styled, Text } from '../../..';
import { IconButton } from '../../../IconButton';
Expand Down Expand Up @@ -89,6 +89,8 @@ export const ChatFooter = ({ onSend, children }: { onSend: (count: number) => vo
const defaultSelection = useDefaultChatSelection();
const selection = selectedPeer.name || selectedRole || defaultSelection;
const isLocalPeerBlacklisted = useIsPeerBlacklisted({ local: true });
const { toggleAudio, toggleVideo } = useAVToggle();
const noAVPermissions = !(toggleAudio || toggleVideo);
const isMwebHLSStream = useMobileHLSStream();
const isLandscapeHLSStream = useLandscapeHLSStream();

Expand Down Expand Up @@ -273,7 +275,7 @@ export const ChatFooter = ({ onSend, children }: { onSend: (count: number) => vo
}}
gap="2"
>
<RaiseHand css={{ bg: '$surface_default' }} />
{noAVPermissions ? <RaiseHand css={{ bg: '$surface_default' }} /> : null}
<MoreSettings elements={elements} screenType={screenType} />
</Flex>
</>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
selectAppData,
selectIsConnectedToRoom,
selectRoomState,
useAVToggle,
useHMSActions,
useHMSStore,
} from '@100mslive/react-sdk';
Expand Down Expand Up @@ -53,6 +54,8 @@ export const ConferenceScreen = () => {
const dropdownListRef = useRef<string[]>();
const [isHLSStarted] = useSetAppDataByKey(APP_DATA.hlsStarted);

const { toggleAudio, toggleVideo } = useAVToggle();
const noAVPermissions = !(toggleAudio || toggleVideo);
// using it in hls stream to show action button when chat is disabled
const showChat = !!screenProps.elements?.chat;
const autoRoomJoined = useRef(isPreviewScreenEnabled);
Expand Down Expand Up @@ -199,7 +202,7 @@ export const ConferenceScreen = () => {
justify="end"
gap="2"
>
<RaiseHand />
{noAVPermissions ? <RaiseHand /> : null}
<MoreSettings elements={screenProps.elements} screenType={screenProps.screenType} />
<Box
css={{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { useEffect } from 'react';
import { useMedia } from 'react-use';
import { ConferencingScreen } from '@100mslive/types-prebuilt';
import { Chat_ChatState } from '@100mslive/types-prebuilt/elements/chat';
import { useAVToggle } from '@100mslive/react-sdk';
import { config as cssConfig, Footer as AppFooter } from '../../..';
// @ts-ignore: No implicit Any
import { AudioVideoToggle } from '../AudioVideoToggle';
Expand Down Expand Up @@ -40,6 +41,8 @@ export const Footer = ({
const isOverlayChat = !!elements?.chat?.is_overlay;
const openByDefault = elements?.chat?.initial_state === Chat_ChatState.CHAT_STATE_OPEN;

const { toggleAudio, toggleVideo } = useAVToggle();
const noAVPermissions = !(toggleAudio || toggleVideo);
const isChatOpen = useIsSidepaneTypeOpen(SIDE_PANE_OPTIONS.CHAT);
const toggleChat = useSidepaneToggle(SIDE_PANE_OPTIONS.CHAT);
const { showPolls } = useShowPolls();
Expand Down Expand Up @@ -87,7 +90,7 @@ export const Footer = ({
>
{isMobile ? (
<>
<RaiseHand />
{noAVPermissions ? <RaiseHand /> : null}
{elements?.chat && <ChatToggle />}
<MoreSettings elements={elements} screenType={screenType} />
</>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import { FullScreenItem } from '../FullScreenItem';
import { MuteAllModal } from '../MuteAllModal';
// @ts-ignore: No implicit any
import { useDropdownList } from '../../hooks/useDropdownList';
// @ts-ignore: No implicit any
import { useMyMetadata } from '../../hooks/useMetadata';
// @ts-ignore: No implicit any
import { APP_DATA, isMacOS } from '../../../common/constants';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
selectIsConnectedToRoom,
selectPeerCount,
selectPermissions,
useAVToggle,
useHMSActions,
useHMSStore,
useRecordingStreaming,
Expand Down Expand Up @@ -50,6 +51,7 @@ import { usePollViewToggle, useSidepaneToggle } from '../../AppData/useSidepane'
import { useShowPolls } from '../../AppData/useUISettings';
// @ts-ignore: No implicit any
import { useDropdownList } from '../../hooks/useDropdownList';
// @ts-ignore: No implicit any
import { useMyMetadata } from '../../hooks/useMetadata';
import { useUnreadPollQuizPresent } from '../../hooks/useUnreadPollQuizPresent';
import { useLandscapeHLSStream, useMobileHLSStream } from '../../../common/hooks';
Expand Down Expand Up @@ -93,6 +95,8 @@ export const MwebOptions = ({
const peerCount = useHMSStore(selectPeerCount);
const emojiCardRef = useRef(null);
const { isBRBOn, toggleBRB, isHandRaised, toggleHandRaise } = useMyMetadata();
const { toggleAudio, toggleVideo } = useAVToggle();
const noAVPermissions = !(toggleAudio || toggleVideo);
const { unreadPollQuiz, setUnreadPollQuiz } = useUnreadPollQuizPresent();
const { title, description } = useRoomLayoutHeader();
const toggleDetailsSheet = useSheetToggle(SHEET_OPTIONS.ROOM_DETAILS);
Expand Down Expand Up @@ -171,7 +175,7 @@ export const MwebOptions = ({
</ActionTile.Root>
)}

{elements.hand_raise ? (
{!noAVPermissions ? (
<ActionTile.Root
active={isHandRaised}
onClick={() => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useEffect } from 'react';
import { selectLocalPeerRoleName, useHMSVanillaStore } from '@100mslive/react-sdk';
// @ts-ignore: No implicit Any
import { useMyMetadata } from './hooks/useMetadata';

export const PreviousRoleInMetadata = () => {
Expand Down
8 changes: 1 addition & 7 deletions packages/roomkit-react/src/Prebuilt/components/RaiseHand.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,11 @@ import { CSS } from '../../Theme';
import { Tooltip } from '../../Tooltip';
// @ts-ignore: No implicit Any
import IconButton from '../IconButton';
import { useRoomLayoutConferencingScreen } from '../provider/roomLayoutProvider/hooks/useRoomLayoutScreen';
// @ts-ignore: No implicit Any
import { useMyMetadata } from './hooks/useMetadata';

export const RaiseHand = ({ css }: { css?: CSS }) => {
const { isHandRaised, toggleHandRaise } = useMyMetadata();
const { elements } = useRoomLayoutConferencingScreen();

if (!elements.hand_raise) {
return null;
}

return (
<Tooltip title={isHandRaised ? 'Lower hand' : 'Raise hand'}>
<IconButton
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { Flex, Text } from '../../..';
import { PreviewControls, PreviewTile } from '../Preview/PreviewJoin';
import { RequestPrompt } from './RequestPrompt';
import { useRoomLayoutPreviewScreen } from '../../provider/roomLayoutProvider/hooks/useRoomLayoutScreen';
// @ts-ignore: No implicit Any
import { useMyMetadata } from '../hooks/useMetadata';
// @ts-ignore: No implicit Any
import { ROLE_CHANGE_DECLINED } from '../../common/constants';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const useMyMetadata = () => {
const metaData = useHMSStore(selectPeerMetadata(localPeerId));
const isHandRaised = useHMSStore(selectHasPeerHandRaised(localPeerId));

const update = async (updatedFields: Record<string, any>) => {
const update = async updatedFields => {
try {
// get current state from store and merge updated fields
const currentMetadata = vanillaStore.getState(selectPeerMetadata(localPeerId));
Expand All @@ -24,7 +24,6 @@ export const useMyMetadata = () => {
} catch (error) {
console.error('failed to update metadata ', updatedFields);
}
return false;
};

const toggleHandRaise = useCallback(async () => {
Expand All @@ -44,12 +43,19 @@ export const useMyMetadata = () => {
}
}, [metaData?.isBRBOn]); //eslint-disable-line

const setPrevRole = async role => {
await update({
prevRole: role,
});
};

return {
isHandRaised,
isBRBOn: !!metaData?.isBRBOn,
metaData,
updateMetaData: update,
toggleHandRaise,
toggleBRB,
setPrevRole,
};
};
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
resolved "https://registry.yarnpkg.com/@100mslive/hms-noise-cancellation/-/hms-noise-cancellation-0.0.0-alpha.5.tgz#8aff14eb7168cbf91a6d54ecb831f88dcda86266"
integrity sha512-C44MLdFrS+4uzWuyauyKCnQ3kOT70jBsGdMXCdCPrK6OPRhZFuMYULYb7XP1NfJjslOcRdENarFqA0T+RNfmuQ==

"@100mslive/[email protected].8":
version "0.12.8"
resolved "https://registry.yarnpkg.com/@100mslive/types-prebuilt/-/types-prebuilt-0.12.8.tgz#2fe9007eb14e66ad3ba687313c4254e2ed085629"
integrity sha512-W1ISh3Mk8/wkomeFiBte7HZLk1gJocnN5U0N8rzZ9WFdDlAW7q/hKgnh+X1/9QxVcv3USfuZyKotbZ7AXmvCiQ==
"@100mslive/[email protected].7":
version "0.12.7"
resolved "https://registry.yarnpkg.com/@100mslive/types-prebuilt/-/types-prebuilt-0.12.7.tgz#66e26701964a8c7a0ab7df4787ac64ad8f8870f4"
integrity sha512-GsDJCZA74+wuBorERQbVA0isRUQduBZzkyzRfMhFA29ZDaVTManrnwamf9TrZvrFJRFTVhZ6lv05oUaauqJRjA==

"@aashutoshrathi/word-wrap@^1.2.3":
version "1.2.6"
Expand Down

0 comments on commit 517e096

Please sign in to comment.