Merge pull request #136 from 100mslive/1.16.4Release

1.16.4 Release
100mslive · Oct 14, 2024 · 1b7f463 · 1b7f463
2 parents 5527ab0 + 7ded477
commit 1b7f463
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 56 deletions.
diff --git a/Example/HMSSDKExample.xcodeproj/project.pbxproj b/Example/HMSSDKExample.xcodeproj/project.pbxproj
diff --git a/Example/HMSSDKExample/Login/LoginViewController.swift b/Example/HMSSDKExample/Login/LoginViewController.swift
@@ -40,6 +40,8 @@ final class LoginViewController: UIViewController {
             Utilities.drawCorner(on: joinMeetingIDField)
         }
     }
+
+    private var collectFeedbackOnAppear = false
 
     @IBOutlet private weak var joinMeetingStackView: UIStackView! {
         didSet {
@@ -75,6 +77,14 @@ final class LoginViewController: UIViewController {
         super.viewWillAppear(animated)
         joinMeetingIDField.text = UserDefaults.standard.string(forKey: Constants.roomIDKey)
     }
+
+    override func viewDidAppear(_ animated: Bool) {
+        super.viewDidAppear(animated)
+        if (collectFeedbackOnAppear) {
+            collectFeedbackOnAppear = false
+            collectFeedback()
+        }
+    }
 
     override func willTransition(to newCollection: UITraitCollection,
                                  with coordinator: UIViewControllerTransitionCoordinator) {
@@ -109,7 +119,7 @@ final class LoginViewController: UIViewController {
         NotificationCenter.default.addObserver(forName: Constants.meetingLeft,
                                                object: nil,
                                                queue: .main) { [weak self] _ in
-            self?.collectFeedback()
+            self?.collectFeedbackOnAppear = true
         }
     }
 

diff --git a/Example/Podfile b/Example/Podfile
@@ -4,7 +4,7 @@ platform :ios, '13.0'
 
 target 'HMSSDKExample' do
   use_frameworks!
-  pod 'HMSSDK', '1.16.3'
+  pod 'HMSSDK', '1.16.4'
   pod 'HMSHLSPlayerSDK', '0.0.2'
   pod 'HMSNoiseCancellationModels', '1.0.0'
   pod 'SwiftyBeaver', '1.9.5'

diff --git a/Example/Podfile.lock b/Example/Podfile.lock
@@ -5,7 +5,7 @@ PODS:
   - HMSHLSPlayerSDK (0.0.2):
     - HMSAnalyticsSDK (= 0.0.2)
   - HMSNoiseCancellationModels (1.0.0)
-  - HMSSDK (1.16.2):
+  - HMSSDK (1.16.3):
     - HMSAnalyticsSDK (= 0.0.2)
     - HMSWebRTC (= 1.0.6171)
   - HMSWebRTC (1.0.6171)
@@ -18,7 +18,7 @@ DEPENDENCIES:
   - HMSBroadcastExtensionSDK (= 1.0.0)
   - HMSHLSPlayerSDK (= 0.0.2)
   - HMSNoiseCancellationModels (= 1.0.0)
-  - HMSSDK (= 1.16.2)
+  - HMSSDK (= 1.16.3)
   - SwiftyBeaver (= 1.9.5)
   - SwiftyGif
   - Zip (= 2.1.2)
@@ -42,12 +42,12 @@ SPEC CHECKSUMS:
   HMSBroadcastExtensionSDK: 0757d80497fddec3952858eb14892fb274f9f3c3
   HMSHLSPlayerSDK: 6a54ad4d12f3dc2270d1ecd24019d71282a4f6a3
   HMSNoiseCancellationModels: a3bda1405a16015632f4bcabd46ce48f35103b02
-  HMSSDK: 7305bd911b287ea275a5fdb9142e01fcfb709490
+  HMSSDK: 2cf66bf3db4a486bbde35a18153c0a49403c0c1f
   HMSWebRTC: f6f4f02a665fda6d9d8a5b223272045c3d9486fb
   SwiftyBeaver: 84069991dd5dca07d7069100985badaca7f0ce82
   SwiftyGif: 93a1cc87bf3a51916001cf8f3d63835fb64c819f
   Zip: b3fef584b147b6e582b2256a9815c897d60ddc67
 
-PODFILE CHECKSUM: fbd5465ddb8103e84270d7082de41c13bf65bb54
+PODFILE CHECKSUM: df11b902b91b048952f8c287209b6df19cb74527
 
 COCOAPODS: 1.15.2
diff --git a/HMSSDK.podspec b/HMSSDK.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'HMSSDK'
-  s.version          = '1.16.3'
+  s.version          = '1.16.4'
   s.summary          = 'HMS Videoconferencing iOS SDK'
 
   s.description      = <<-DESC
@@ -10,8 +10,8 @@ TODO: Add long description of the pod here.
   s.homepage         = 'https://github.com/100mslive/100ms-ios-sdk/'
   s.license          = { :type => 'MIT'}
   s.author           = { 'Dmitry Fedoseyev' => '[email protected]', 'Yogesh Singh' => '[email protected]', 'Pawan Dixit' => '[email protected]'}
-  s.source           = { :http => 'https://github.com/100mslive/100ms-ios-sdk/releases/download/1.16.3/HMSSDK.xcframework.zip',
-                           :sha256 => '9864dba2fcf3b6a12f8c7592a247c4139258042161e3d8093f235ea7fa046b8c'
+  s.source           = { :http => 'https://github.com/100mslive/100ms-ios-sdk/releases/download/1.16.4/HMSSDK.xcframework.zip',
+                           :sha256 => '1db0705e3204d8fb9b2d3b8be75a9e3ab31938731e50939d1f09b3fc399de8c5'
 						}
   s.ios.deployment_target = '12.0'
   s.vendored_frameworks = 'HMSSDK.xcframework'

diff --git a/Package.swift b/Package.swift
@@ -16,8 +16,8 @@ let package = Package(
     targets: [
         .binaryTarget(
             name: "HMSSDK",
-            url: "https://github.com/100mslive/100ms-ios-sdk/releases/download/1.16.3/HMSSDK.xcframework.zip",
-            checksum: "9864dba2fcf3b6a12f8c7592a247c4139258042161e3d8093f235ea7fa046b8c"
+            url: "https://github.com/100mslive/100ms-ios-sdk/releases/download/1.16.4/HMSSDK.xcframework.zip",
+            checksum: "1db0705e3204d8fb9b2d3b8be75a9e3ab31938731e50939d1f09b3fc399de8c5"
         ),
         .binaryTarget(
             name: "WebRTC",